Skip to content

Conversation

@rmnbrd
Copy link
Contributor

@rmnbrd rmnbrd commented Jan 27, 2026

Summary

Issue: QOV-1542

This PR fixes an issue where the Git repo URL was missing from the checkDockerfile request's payload when selecting a public repo.

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

There is no better time than now, better future does not exist

@rmnbrd rmnbrd self-assigned this Jan 27, 2026
@rmnbrd rmnbrd force-pushed the fix/QOV-1542/git-public-check-dockerfile branch from 295ce94 to 85783d5 Compare January 27, 2026 15:13
@rmnbrd
Copy link
Contributor Author

rmnbrd commented Jan 27, 2026

/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425

@RemiBonnet
Copy link
Member

Qovery Preview

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - fix: Git repo URL missing from checkDockerfile request's payload when using public repo - 2026-01-27T15:14:15Z

Another comment will be posted when deployments are finished

@RemiBonnet
Copy link
Member

Qovery Preview

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.43%. Comparing base (c81f0a5) to head (88a7f73).
⚠️ Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...ture/step-general-feature/step-general-feature.tsx 0.00% 1 Missing ⚠️
...tep-dockerfile-feature/step-dockerfile-feature.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2337      +/-   ##
===========================================
- Coverage    47.53%   47.43%   -0.10%     
===========================================
  Files         1279     1249      -30     
  Lines        23524    22750     -774     
  Branches      6931     6708     -223     
===========================================
- Hits         11182    10792     -390     
+ Misses       10191     9868     -323     
+ Partials      2151     2090      -61     
Flag Coverage Δ
unittests 47.43% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd merged commit 2889793 into staging Jan 27, 2026
10 checks passed
@rmnbrd rmnbrd deleted the fix/QOV-1542/git-public-check-dockerfile branch January 27, 2026 15:59
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.273.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants