fix(release): SBOM path glob so best-effort SBOM never blocks release (Sigilix P1) - #7
Merged
Merged
Conversation
…he release Sigilix (PR #6, P1): gh release create referenced the literal 9lives.cdx.json, but shopt -s nullglob only skips *globs* — a missing SBOM (its step is continue-on-error) would make gh release create fail with 'no such file', contradicting the best-effort intent. Use *.cdx.json so nullglob drops it when absent. The v0.1.3 run only survived because the SBOM step happened to succeed.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Sigilix is reviewing this pull request. A structured overview will replace this note when retrieval and specialist review complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the P1 Sigilix flagged on #6. The
gh release createstep passed the literal9lives.cdx.json;shopt -s nullglobonly skips globs, so if the best-effort (continue-on-error) SBOM step failed,gh release createwould error with 'no such file' and block the release. Now*.cdx.json— nullglob drops it when absent. (v0.1.3 only shipped because the SBOM step happened to succeed.)