Skip to content

fix(release): SBOM path glob so best-effort SBOM never blocks release (Sigilix P1) - #7

Merged
Desperado merged 1 commit into
mainfrom
fix/sigilix-sbom-release-glob
Jul 9, 2026
Merged

fix(release): SBOM path glob so best-effort SBOM never blocks release (Sigilix P1)#7
Desperado merged 1 commit into
mainfrom
fix/sigilix-sbom-release-glob

Conversation

@Desperado

Copy link
Copy Markdown
Contributor

Addresses the P1 Sigilix flagged on #6. The gh release create step passed the literal 9lives.cdx.json; shopt -s nullglob only skips globs, so if the best-effort (continue-on-error) SBOM step failed, gh release create would error with 'no such file' and block the release. Now *.cdx.json — nullglob drops it when absent. (v0.1.3 only shipped because the SBOM step happened to succeed.)

…he release

Sigilix (PR #6, P1): gh release create referenced the literal 9lives.cdx.json,
but shopt -s nullglob only skips *globs* — a missing SBOM (its step is
continue-on-error) would make gh release create fail with 'no such file',
contradicting the best-effort intent. Use *.cdx.json so nullglob drops it
when absent. The v0.1.3 run only survived because the SBOM step happened to
succeed.
@cursor

cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@sigilix

sigilix Bot commented Jul 9, 2026

Copy link
Copy Markdown

Posted · 99ecc1a · 0 findings — View review

Sigilix is reviewing this pull request.

A structured overview will replace this note when retrieval and specialist review complete.

== cartographer's window ==
     .--------------------------------------------------.
    /  o      o      o      o      o      o      o      \
   |------------------------------------------------------|
   |   .       *          .--------.          *       .   |
   |        .            /  branch \              .       |
   |   *          .-----*----*-----*----.             *   |
   |             /       \    \     \    \                |
   |      .     *----*----*----*-----*----*      .        |
   |             \        \    \     \    /               |
   |   .          '----*---*----*---*----'        *       |
   |        *          \        .       /                 |
   |   map what changed, keep what matters        .       |
   |------------------------------------------------------|
    \__o______o______o______o______o______o______o_____/
          .              .           *              .

each branch becomes a little sky
we map the risk before the road

@sigilix sigilix Bot added the bug Something isn't working label Jul 9, 2026
@Desperado
Desperado merged commit 5b04b90 into main Jul 9, 2026
5 checks passed
@Desperado
Desperado deleted the fix/sigilix-sbom-release-glob branch July 9, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant