Fix for afterTest Hook - test.passed to passed#51
Open
himanshujane3 wants to merge 1 commit into
Open
Conversation
test.passed is always undefined as there is no such property condition should be checking for passed property This was causing unnecessary screenshot after each test.
Contributor
|
hi @himanshujane3 Ive not really looked at this with version 6 of wdio |
Author
|
Hi @benzaremean I have verified this with latest version of wdio - Please accept the PR |
Author
|
Hi @benzaremean As updated in my previous comment. This changes is absolutely safe, could you please accept the PR |
|
Has this been tested on the latest version of wdio? The afterTest function takes 3 params, with results being the 3rd one Need to add the context param, otherwise passed is still undefined. |
|
@benzaremean Is there any chance this PR gets reviewed and merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test.passed is always undefined as there is no such property
condition should be checking for passed property
This was causing unnecessary screenshot after each test.