Repository navigation
Conversation
Add an agent-authored diff-note surface: CLI (diff-note create/list/rm), RPC (diffNote.create/list/delete), runtime persistence onto WorktreeMeta.diffComments, and renderer styling (sparkles badge + rationale) distinct from human review notes. Ships the orca-diff-notes skill stub/guide.
The first version produced line-by-line restatements of the code instead of findings worth a reviewer's time, and each note cost ~3x the vertical space it needed. Skill: - Frame the task as reviewing a changeset, not narrating your own work; drop the "implement the change" workflow step that caused self-narration. - Redefine --rationale as the consequence and the choice it forces, not the "why it's safe" justification that produced reassurance prose. - Add the value bar (must change what the reader does next), a rejection test, and a read-outward step, since the findings worth reading come from call sites the diff never touched. - No per-hunk cap: an earlier one-note-per-hunk budget suppressed the better of two real findings sharing a hunk. Cap rationale at two sentences instead. - Resolve the CLI by capability probe rather than by ORCA_DEV_REPO_ROOT, which is not exported in Orca terminals and selected a build without diff-note. Renderer: - Widen agent notes to the code column and drop the boxed, labelled rationale block: 150px -> 78px per note, measured, with no loss of content.
ORCA_SKILLS_REPOSITORY_URL was hardcoded to stablyai/orca, so `orca skills install --skill orca-diff-notes` resolved a repo that doesn't carry the skill this fork added. Repoint it here so the standard install path works for every bundled skill, including ones only this fork ships. Scoped to the skill-install constant only. The app's other stablyai/orca references (GitHub star buttons, changelog links, docs site) are unrelated product links, not the install source, and are left alone.
herdr-style popup: green-bordered bottom-center box in the pane theme's ANSI green, shown 2s after a successful copy. Cmd/Ctrl+C shows it immediately; copy-on-select waits out a 200ms quiet window so one drag shows one popup at mouse release, never one per character. Renders via per-pane portal into pane.container; timers prune on pane close. Plan + progress: terminal-copy-feedback-popup.plan.md
feat(terminal): copied-to-clipboard feedback popup
…on (stablyai#19771) * fix(push): isolate deployment and validate candidates before activation * test(push): classify dedicated rollout outside shared SQL lock census * test(push): verify independent deployment identity and lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.typfiles across editor and diff surfacesVerification
ORCA_BACKGROUND_LAUNCH=1 pnpm test src/renderer/src/lib/language-detect.test.ts src/renderer/src/lib/monaco-languages/register-typst.test.tsORCA_BACKGROUND_LAUNCH=1 pnpm run typecheck:webORCA_BACKGROUND_LAUNCH=1 pnpm run check:code-quality:changed