Skip to content

MAINT: Rephrase pejorative wording in test_lqnash comment - #910

Open
jasperdingg wants to merge 3 commits into
QuantEcon:mainfrom
jasperdingg:maint/rephrase-test-comment
Open

MAINT: Rephrase pejorative wording in test_lqnash comment#910
jasperdingg wants to merge 3 commits into
QuantEcon:mainfrom
jasperdingg:maint/rephrase-test-comment

Conversation

@jasperdingg

Copy link
Copy Markdown

Closes #901, rephrased comment in test_lqnash.py. Confirmed that term doesn't appear elsewhere.

@jasperdingg

Copy link
Copy Markdown
Author

Hi @mmcky, quick follow up on #910!

@mmcky mmcky added the author-response Waiting on author response label Sep 9, 2026

@quantecon-services quantecon-services left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jasperdingg 👋 Thanks for picking this up, and apologies for the slow turnaround on a small PR.

This does exactly what #901 asked for. The rewording keeps the underlying TODO about hardcoded MATLAB reference values while stating it plainly, and I independently confirmed the grep: the line you changed is the only occurrence of that word anywhere in the tree. The branch also merges cleanly onto current main, so nothing else is needed on that front.

I've left one inline nit (a whitespace-only blank line) with a suggestion you can accept in one click. Once that's in, this is good to merge.

One friendly request. QuantEcon is currently drafting an AI disclosure policy for contributions (see QuantEcon/qeps#13). It isn't in force yet, but it would help us as we shape the policy if you could add a short note to the PR description saying whether AI tools were used in preparing this PR and, if so, which tools or models (e.g. "drafted with Claude Code / Copilot / ChatGPT, then reviewed and tested by hand"). "No AI tools used" is an equally welcome answer.

The goal is transparency rather than gatekeeping. AI-assisted contributions are fine, we'd just like the provenance recorded.


Generated by Claude Code

Comment thread quantecon/tests/test_lqnash.py Outdated
mmcky and others added 2 commits September 10, 2026 09:05
Co-authored-by: QuantEcon <quantecon-services@users.noreply.github.com>
@mmcky mmcky added the ready label Sep 9, 2026
@coveralls

coveralls commented Sep 9, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 90.884%. remained the same — jasperdingg:maint/rephrase-test-comment into QuantEcon:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author-response Waiting on author response ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MAINT: Replace pejorative wording in a test comment

4 participants