Skip to content

Harden linkcheck release-asset extract against partial downloads #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmcky merged 1 commit into from
Jul 7, 2026
Merged

Harden linkcheck release-asset extract against partial downloads #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/linkcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,14 @@ jobs:
--jq '.assets[] | select(.name | endswith(".tar.gz")) | .browser_download_url' 2>/dev/null | head -1 || true)
mkdir -p _site
if [ -n "$asset_url" ]; then
curl -sSL "$asset_url" | tar -xz -C _site || true
# `curl -f` fails on HTTP errors; an `if !` guard catches a failed
# or partial download/extract and discards the incomplete tree, so
# lychee never runs against a half-extracted site (which would
# reintroduce "file not found" false positives).
if ! curl -fsSL "$asset_url" | tar -xz -C _site; then
echo "::warning::could not download/extract $asset_url — treating as no usable asset"
rm -rf _site && mkdir -p _site
fi
fi
count=$(find _site -name '*.html' | wc -l | tr -d ' ')
echo "Extracted $count HTML file(s) from the latest release asset"
Expand Down
Loading