Add actions: read for the cache artifact download - #219
Merged
Merged
Conversation
The explicit permissions block set all unlisted scopes to none, so the dawidd6/action-download-artifact step (which reads the build cache from cache.yml via the Actions API) had no actions:read. The last publish still succeeded, but the scope is the documented requirement and matches the permissions example in QuantEcon/meta#282 — add it to guarantee the cache download and keep this in sync with lecture-jax. Ports the fix from QuantEcon/lecture-jax#331 (Copilot review follow-up). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for adorable-cucurucho-69162b ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for sparkly-moxie-de1f0e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Pages publish workflow token permissions to include actions: read, aligning with the documented requirement for dawidd6/action-download-artifact when downloading artifacts from another workflow (cache.yml).
Changes:
- Add
actions: readto thepermissions:block in.github/workflows/publish.ymlto support downloading the build cache artifact via the Actions API.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the fix from QuantEcon/lecture-jax#331 (a Copilot-review catch) to keep the two repos' publish workflows in sync.
Why
The migration added an explicit
permissions:block, which sets every unlisted scope tonone. The publish job'sdawidd6/action-download-artifactstep reads the Jupyter build cache fromcache.ymlvia the Actions API, which needsactions: read.The last publish (
publish-2026jul07) still succeeded with only Contents/Metadata/Pages granted — so this isn't currently breaking — butactions: readis the documented requirement for that action and is exactly what issue QuantEcon/meta#282's permissions example lists (actions: read # needed if other workflows download artifacts). Adding it guarantees the cache download and removes a latent gap.Change
One line added to the
permissions:block in.github/workflows/publish.yml:🤖 Generated with Claude Code