Record the 2026-09-01 register review in both diverged manifests - #108
Merged
Conversation
#39's post-migration review kept both frozen copies deliberately. The register's own rule is that an entry and its manifest must not diverge, so each integrity.upstream.note now says the delta was reviewed and kept, and why, rather than only that it exists. CATALOG.md does not render the note, so it is unchanged. See #39. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates dataset manifests to reflect the post-migration upstream-delta register review (#39), so the manifests’ integrity.upstream.note fields explicitly record that the known upstream deltas were reviewed and intentionally kept.
Changes:
- Extend
integrity.upstream.noteinmpd2020.xlsx.ymlto record the register review outcome and rationale. - Extend
integrity.upstream.noteinlife-expectancy-vs-gdp-per-capita.csv.ymlto record the register review outcome and rationale.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lectures/mpd2020.xlsx.yml | Adds register-review outcome to the upstream-divergence note (and rationale) for the known local header-label edits. |
| lectures/life-expectancy-vs-gdp-per-capita.csv.yml | Adds register-review outcome to the upstream-divergence note (and rationale) for the known “upstream moved” vintage delta. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot review on #108: the manifest's consumers block lists four repos, including test-actions-lecture-intro. Under-counting the canary is the mistake repoint rule 1 exists to prevent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-through from the #39 register review posted today, which kept both frozen copies deliberately —
mpd2020.xlsx(local edit, load-bearing labels on the current Maddison release) andlife-expectancy-vs-gdp-per-capita.csv(upstream moved; adoption would be a lecture-content change with no reader benefit).#39's own rule is that a register entry and its manifest must not diverge, and until now each manifest's
integrity.upstream.notesaid only that the delta exists. Each note now also says it was reviewed on 2026-09-01 and kept, with the one-sentence reason, so a reader of the manifest or the catalog's ⇄ mark sees an adjudicated delta rather than an unresolved one. No status, class, hash or schema field changes;CATALOG.mddoes not render the note and is unchanged (regenerated to confirm).See #39.
🤖 Generated with Claude Code