Annotate the new bivariate_dist yfinance read — main is red without it - #94
Merged
Merged
Conversation
lecture-python-intro#837 added lectures/bivariate_dist.md, which downloads AMZN and COST monthly closes through yfinance in a solved exercise. The strict audit fails on any live-API read with no `api:` annotation — by design, so a new fetch in a lecture repo cannot appear here silently — so the audit-dashboard build on main has been failing since that lecture landed (run 31984234688, the sole warning being `missing_api_annotations: lecture-python-intro:bivariate_dist:yfinance`). Nothing to do with wave C1, which merged shortly before: the same run reported zero problems in every other bucket, and re-running the scan here with the annotation added exits 0 with all five buckets empty. Worth noting how the timing hid it. This repo's audit reads the CONSUMING repos, so a lecture-repo merge can turn main red here with no change to this repo at all, and nothing in lecture-python-intro reports it. The local run against a clone that predated the new lecture passed; it only failed once CI cloned intro fresh. `pedagogy: incidental` follows the sibling reads — the lecture points at observed_distributions for the same workflow, so the download is the illustration's input rather than its lesson. CATALOG.md is unaffected; api annotations do not feed the generated catalog. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a missing strict-audit annotation for a newly introduced live API call (yfinance) in lecture-python-intro so this repository’s audit passes again and main returns to green.
Changes:
- Adds an
api:annotation forlecture-python-intro:bivariate_dist:yfinance, documenting the series (AMZN, COST), pedagogy classification, and rationale.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been failing since lecture-python-intro#837 addedlectures/bivariate_dist.md, which downloads AMZN and COST monthly closes throughyfinance. The strict audit fails on any live-API read with noapi:annotation — by design, so a new fetch in a lecture repo cannot land here silently.Run 31984234688's only warning was
missing_api_annotations: lecture-python-intro:bivariate_dist:yfinance; every other bucket was empty, so this is unrelated to wave C1 which merged just before it.Worth recording how the timing hid this. This repo's audit reads the consuming repos, so a merge in a lecture repo can turn
mainred here with no change to this repo at all — and nothing on the lecture-repo side reports it. A local run against a clone that predated the new lecture passed; the failure only appeared once CI cloned intro fresh. Anyone diagnosing a redmainhere should check what landed in the lecture repos, not just what landed here.pedagogy: incidentalmatches the sibling yfinance reads: the lecture explicitly points atobserved_distributionsfor the same workflow, so the download is the illustration's input rather than its lesson.Verified: strict audit exits 0 with all five problem buckets empty;
CATALOG.mdregenerates unchanged, sinceapi:annotations do not feed the generated catalog.🤖 Generated with Claude Code