Set interim site base URL to the github.io Pages default - #41
Merged
Merged
Conversation
The DP lectures are served at https://quantecon.github.io/lecture-dp/, but _config.yml still pointed html.baseurl (and the tojupyter URL paths) at https://dp.quantecon.org/ — which now serves a separate book landing page. That mismatch bakes dp.quantecon.org self-links and downloaded-notebook URLs into the build, all of which 404. Point baseurl, tojupyter_urlpath, and tojupyter_image_urlpath at the current github.io host so self-links and notebook URLs resolve. Interim setting until the final custom URL is decided in #2 — revisit then. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Jupyter Book configuration so the published lecture site and generated notebook URLs point at the current GitHub Pages host (https://quantecon.github.io/lecture-dp/) instead of the deprecated https://dp.quantecon.org/, avoiding baked-in links that now 404.
Changes:
- Set
html.baseurltohttps://quantecon.github.io/lecture-dp/. - Set
sphinx.config.tojupyter_urlpathtohttps://quantecon.github.io/lecture-dp/. - Set
sphinx.config.tojupyter_image_urlpathtohttps://quantecon.github.io/lecture-dp/_static/.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Points the site base URL at the current GitHub Pages host,
https://quantecon.github.io/lecture-dp/, as an interim setting.Why
The DP lectures are currently served at
https://quantecon.github.io/lecture-dp/(Pagescnameis null), butlectures/_config.ymlstill pointed athttps://dp.quantecon.org/, which now serves a separate book landing page. That mismatch bakesdp.quantecon.orglinks into the build that all 404:html.baseurl→ canonical + absolute self-links between lecture pagestojupyter_urlpath→ URLs written into the downloadable notebookstojupyter_image_urlpath→ image URLs in the downloadable notebooksA quick check confirms the mismatch:
https://dp.quantecon.org/intro.html→ 404, whilehttps://quantecon.github.io/lecture-dp/intro.html→ 200.Change
Three keys in
lectures/_config.yml,https://dp.quantecon.org/→https://quantecon.github.io/lecture-dp/(and the/_static/variant).Interim, pending the final URL
This is deliberately a stopgap so the published site's internal links and notebook URLs resolve today. The permanent custom URL is still being decided in #2 — this should be revisited (and updated once more) when that lands.
Related
dp.quantecon.org404s.🤖 Generated with Claude Code