Drop nb_repository_url, which points at a notebooks repo that does not exist - #279
Open
mmcky wants to merge 1 commit into
Open
Drop nb_repository_url, which points at a notebooks repo that does not exist#279mmcky wants to merge 1 commit into
mmcky wants to merge 1 commit into
Conversation
…t exist lectures/_config.yml set nb_repository_url to https://github.com/QuantEcon/lecture-python.zh-cn.notebooks, which returns 404. quantecon-book-theme renders its Launch button whenever the key is set, so every page linked Colab to the missing repository. Leaves the comment the lecture-python-programming editions use for the same case; the theme skips notebook-launch links when the key is unset. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, YAML-valid, and removes a configuration value that currently causes broken launch links without impacting other settings.
Pull request overview
Removes the nb_repository_url setting from the Sphinx theme configuration so the site theme no longer renders notebook “Launch” links that point to a non-existent notebooks repository.
Changes:
- Drop
nb_repository_urlfromlectures/_config.ymlto disable notebook-launch buttons. - Add an inline comment explaining why the key is intentionally omitted.
File summaries
| File | Description |
|---|---|
| lectures/_config.yml | Removes nb_repository_url to prevent broken Colab/notebook launch links and documents the intentional omission. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 11, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lectures/_config.ymlsetsnb_repository_urltohttps://github.com/QuantEcon/lecture-python.zh-cn.notebooks, a repository that does not exist. quantecon-book-theme shows its Launch button whenever that key is set, so every page links Colab to the missing repository. For example, https://quantecon.github.io/lecture-python.zh-cn/intro.html links tohttps://colab.research.google.com/github/QuantEcon/lecture-python.zh-cn.notebooks/blob/main/intro.ipynb, andQuantEcon/lecture-python.zh-cn.notebooksreturns 404 (checked 2026-09-11).This removes the key and leaves the same comment the lecture-python-programming editions use for this situation (see QuantEcon/lecture-python-programming.fa#145). With the key unset, the theme renders no Launch button. Nothing else in the theme reads the key.
Translation sync. action-translation's sync reads this file only to find bibliographies, so it will not restore the key. The CLI's
translate initdoes copy_config.ymlfrom the English source, but that already overwrites every localized setting and is documented as needing a revert.Publishing. Merging does not change the live site; the button disappears at the next
publish*release. The same change is going to lecture-dp and lecture-intro.zh-cn under the same title.Found during the book-theme parity review for the MyST theme (QuantEcon/quantecon-theme.mystmd#205), which will show Launch only when a notebook source is configured.
🤖 Generated with Claude Code