MAINT: migrate RunsOn disk=large → volume=80gb (v3 pilot) - #51
Conversation
RunsOn v3 parses but ignores the disk= label and would silently boot runners with the image's default root volume instead of the 80GB "large" volume. Replace disk=large with volume=80gb across all four RunsOn workflows (ci, cache, publish, collab) so jobs keep adequate disk headroom on the new v3 stack. lecture-stats is the v3 pilot. Part of QuantEcon/meta#322 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✅ Deploy Preview for timely-seahorse-68815c ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Migrates this repository’s RunsOn GitHub Actions workflows to the RunsOn v3-compatible disk sizing label by replacing disk=large (ignored on v3) with volume=80gb to avoid running jobs on undersized default root volumes.
Changes:
- Replaced
disk=largewithvolume=80gbin all RunsOnruns-on:labels. - Kept existing
family=andimage=selections unchanged across workflows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Updates RunsOn label to use volume=80gb for PR CI runs. |
| .github/workflows/collab.yml | Updates RunsOn label to use volume=80gb for PR GPU container job. |
| .github/workflows/cache.yml | Updates RunsOn label to use volume=80gb for scheduled/manual cache builds. |
| .github/workflows/publish.yml | Updates RunsOn label to use volume=80gb for tag-based publish runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…#54) Lands #51, #52, #53 and #50 as one change, and salvages the -n flag from #25. - runs-on: disk=large -> volume=80gb, plus spot=false, on all four GPU workflows. Now matches lecture-jax and lecture-python.myst byte for byte, allowing for collab.yml's different image. - Explicit permissions blocks on ci.yml, collab.yml and publish.yml so the default workflow token can drop to read. ci.yml and collab.yml also gain actions: read, which #53 declared only on publish.yml. - dawidd6/action-download-artifact -> @v21 at all four call sites; collab.yml was still on v3 while the rest were on v9. - -n added to the ci.yml PDF build so it matches publish.yml, closing a gap where a nitpick-class error passed the PR check and failed at publish time. #51, #52 and #53 conflicted pairwise over the same region of ci.yml and collab.yml, so they are resolved once here rather than through two sequential rebases. Part of the rollout tracked in QuantEcon/meta#330, with the permissions work from QuantEcon/meta#347. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Landed via #54, which set Merged there rather than here because #51, #52 and #53 all rewrote the same few lines of |
Migrates
lecture-statsto the RunsOn v3 stack as the migration pilot for QuantEcon/meta#322.In v3 the
disk=label is parsed but ignored — a runner pointed at a v3 stack withdisk=largesilently boots with the image's default root volume, which can fail GPU build jobs with "no space left on device". This PR replacesdisk=large→volume=80gb(the documented v3 equivalent; matches the v2 stack's 80GB large-volume size) across all four RunsOn workflows. Thefamily=andimage=parts are unchanged.ci.ymlquantecon_ubuntu2404(custom AMI)pull_request— runs on this PRcollab.ymlubuntu24-gpu-x64(RunsOn default GPU)pull_request— runs on this PRcache.ymlquantecon_ubuntu2404workflow_dispatch— validated separatelypublish.ymlquantecon_ubuntu2404publish*— rides the same proven labelThis must merge together with the v3 cutover (v3 GitHub App now installed on
lecture-stats, removed from the v2 app) — not before, since v2 doesn't understandvolume=.Part of QuantEcon/meta#322
🤖 Generated with Claude Code