Skip to content

Add explicit permissions blocks so the default token can drop to read #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmcky wants to merge 1 commit into from
Closed

Add explicit permissions blocks so the default token can drop to read #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ on: [pull_request]
jobs:
preview:
runs-on: "runs-on=${{ github.run_id }}/family=g4dn.2xlarge/image=quantecon_ubuntu2404/disk=large"
permissions:
contents: read
pull-requests: write
Comment on lines +6 to +8

@mmcky mmcky Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed — this PR was superseded by #54, whose consolidated block for ci.yml includes actions: read.

steps:
- uses: actions/checkout@v4
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/collab.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ on: [pull_request]
jobs:
execution-checks:
runs-on: "runs-on=${{ github.run_id }}/family=g4dn.2xlarge/image=ubuntu24-gpu-x64/disk=large"
permissions:
contents: read
pull-requests: write
Comment on lines +6 to +8

@mmcky mmcky Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed — this PR was superseded by #54, whose consolidated block for collab.yml includes actions: read.

container:
image: docker://us-docker.pkg.dev/colab-images/public/runtime
options: --gpus all
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ on:
push:
tags:
- 'publish*'
permissions:
contents: write # peaceiris/actions-gh-pages pushes the built site to gh-pages
actions: read # dawidd6/action-download-artifact reads the cache.yml build artifact
Comment on lines +6 to +8

@mmcky mmcky Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair catch, and now addressed in #55 — linkcheck.yml gets the same contents: read + actions: read block. For the record the download works today without it (public-repo Actions reads accept a token without the scope — the sibling repos' ci workflows rely on the same leniency), so #55 is consistency hardening rather than a live fix.

jobs:
publish:
if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags')
Expand Down
Loading