french_rev: read the five datasets from data-lectures - #55
Merged
Conversation
Repoints french_rev off lecture-python-intro's committed copies and onto QuantEcon/data-lectures, and deletes this repo's unused mirror copies. The URL form stays raw.githubusercontent.com, per repoint rule 5 — this site executes its code cells in the reader's browser, and the github.com/*/raw/ form is a 302 whose response carries an empty access-control-allow-origin. Only base_url's org, repo and path change. Verified: all five files return 200 with access-control-allow-origin: * on this host, serving bytes identical to the copies the lecture read before. The six deleted files under lectures/datasets/ were mirror-orphans — nothing in this repo read them, since french_rev has always fetched intro's copies by URL. fig_3.ods is included: it is a format twin of fig_3.xlsx that nothing anywhere references, and data-lectures dropped it for that reason. The two remaining files in that directory belong to another lecture. The three markdown links under "Data Sources" are repointed as well. They pointed into lecture-python-intro and no build checks them, so they would have 404'd silently once intro deletes its copies. Pairs with QuantEcon/lecture-python-intro#826 — both must land together, per repoint rule 2. Part of QuantEcon/workspace-lectures#23. Data: QuantEcon/data-lectures#49.
❌ Deploy Preview for beautiful-dodol-cb9543 failed.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the french_rev lecture to source its spreadsheet and binary datasets from QuantEcon/data-lectures (using the raw.githubusercontent.com URL form to avoid CORS issues in in-browser execution) and repoints the “Data Sources” prose links accordingly.
Changes:
- Repointed the three “Data Sources” markdown links from
lecture-python-introtodata-lectures. - Updated the
base_urlused by the lecture’s code to fetch datasets fromQuantEcon/data-lectures/main/lectures/.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📖 Netlify Preview Ready! Preview URL: https://pr-55--beautiful-dodol-cb9543.netlify.app (3f3a8da) ✨ Browse the preview at the URL above. |
mmcky
added a commit
to QuantEcon/data-lectures
that referenced
this pull request
Aug 7, 2026
…#49) Flips assignat.xlsx, dette.xlsx, fig_3.xlsx, caron.npy and nom_balances.npy from landed to repointed, and fills in their consumers now that both lectures read them from here. migration.yml is 18 repointed, 0 landed. Hold this as a draft until QuantEcon/lecture-python-intro#826 and QuantEcon/lecture-wasm#55 have both merged. `build_audit.py` scans each consuming repo's origin/main, so while those PRs are open a strict run reports five migration_inconsistencies and exits 1 — the deliberate no-green-state window for a partially-repointed dataset (repoint rule 2). It goes green once both land; nothing else is required here. Also drops nine stale mirror-orphan annotations for lecture-wasm files that no longer exist. Six are deleted by lecture-wasm#55 in this same set; the other three (chapter_3.xlsx, longprices.xls, mpd2020.xlsx) were deleted during sets 1 and 2 and their annotations were left behind. All nine confirmed absent from that repo's working tree. check_consumed_files.py now covers 18 of 18 files, 0 errors — the five new consumer entries put these datasets under the required byte check for the first time. Part of QuantEcon/workspace-lectures#23.
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repoints
french_revofflecture-python-intro's committed copies and onto QuantEcon/data-lectures, and deletes this repo's unused mirror copies. Part of QuantEcon/workspace-lectures#23 (step 2); data-side record in QuantEcon/data-lectures#49.The URL form is deliberate
base_urlkeeps theraw.githubusercontent.comhost — only the org, repo and path change:This is repoint rule 5. This site executes its code cells in the reader's browser, so every
pd.read_*(url)is a CORS-checked cross-origin fetch, and thegithub.com/<org>/<repo>/raw/form intro uses is a 302 whose response carries an emptyaccess-control-allow-origin— rejected before the redirect is followed. Normalising these URLs to intro's form is exactly the regression QuantEcon/data-lectures#46 records.Verified on the target host: all five return 200 with
access-control-allow-origin: *, serving bytes identical to the copies the lecture read before.assignat.xlsx*dette.xlsx*fig_3.xlsx*caron.npy*nom_balances.npy*The
.npyreads already usedrequests+BytesIO, so they needed no change beyondbase_url.Deletions
The six files removed from
lectures/datasets/were mirror-orphans — nothing in this repo read them, becausefrench_revhas always fetched intro's copies by URL. data-lectures' audit classifies all six that way.fig_3.odsis included: it is a format twin offig_3.xlsxthat nothing anywhere references, and data-lectures dropped it for that reason during the restructure. The two remaining files in that directory belong to another lecture and are untouched.Prose links
The three markdown links under Data Sources pointed into
lecture-python-intro. No build checks them, so they would have 404'd silently once intro deletes its copies. Repointed here — two of the references inventoried in QuantEcon/data-lectures#42.Sequencing
Must land in the same set as QuantEcon/lecture-python-intro#826, per repoint rule 2. While only one side has merged, data-lectures' strict audit fails by design — there is no green state for a partially-repointed dataset. Merging this one first is what happened in set 2 and left the audit red for 47 minutes.
No publish split is needed on this repo: it publishes on push to
main, so the site andmainnever diverge.🤖 Generated with Claude Code