Skip to content

chore: bump the pinned theme to v2.5.0 and restore the short_path graph cell - #72

Merged
mmcky merged 1 commit into
mainfrom
chore/bump-theme-v2.5.0
Sep 7, 2026
Merged

chore: bump the pinned theme to v2.5.0 and restore the short_path graph cell#72
mmcky merged 1 commit into
mainfrom
chore/bump-theme-v2.5.0

Conversation

@mmcky

@mmcky mmcky commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Bumps the pinned lecture theme from v2.3.0 to v2.5.0 and moves the short_path graph-data cell back inside its exercise, now that the theme carries the fix the workaround was for. See #71.

What is broken on the live site

The deployed KaTeX stylesheet references its 60 font files under /myst_assets_folder/_assets/, a path a static build never creates, so every one of them 404s and every maths glyph falls back to a system font. Re-verified against the live site on 2026-09-07. The cause is QuantEcon/quantecon-theme.mystmd#138, fixed in v2.3.1 and completed in v2.4.0 (four route and shared-chunk stylesheets the first fix missed). This site is the only mystmd consumer, and no bot bumps a site.template URL, which is why the pin fell two releases behind.

What the bump brings

Release What this site gets
v2.3.1 Relative stylesheet asset URLs (the font 404s); code cells nested in a directive register with the kernel (QuantEcon/quantecon-theme.mystmd#117)
v2.4.0 The asset fix completed across every stylesheet; inline code no longer renders wrapped in literal backticks; Sphinx-matching content typography, footer and back-to-top
v2.5.0 PT Serif headings and QuantEcon-blue links matching the Sphinx lectures; icon-only search trigger; the notebook launcher collapses to Colab; every toolbar control gets a proper accessible name

The launcher change is safe here: this site enables JupyterLite and never configured the Private JupyterHub option that v2.5.0 removes. The typography changes are visible, and are the direction the theme's parity work is taking every lecture site.

The short_path revert

#63 moved the %%file graph.txt cell out of the exercise because, on v2.3.0, a code cell nested in any directive rendered a run button that did nothing and the solution then failed with FileNotFoundError. Its comment said to move the cell back once QuantEcon/quantecon-theme.mystmd#117 shipped. It shipped in v2.3.1. The cell returns to where it sits in lecture-python-intro and the other five repos that carry this exercise, and the comment goes.

Verification

  • Local myst build --html against the v2.5.0 template completes.
  • The built stylesheets contain no absolute /myst_assets_folder URLs.

Not touched: #56 (root-relative myst-theme.css, favicon and service-worker URLs ignoring BASE_URL), which is a defect in this repository's own configuration.

🤖 Generated with Claude Code

…ph cell

The site pinned quantecon-theme.mystmd v2.3.0 and served 60 KaTeX font
404s (theme#138, fixed in v2.3.1 and completed in v2.4.0). v2.5.0 also
brings the Sphinx-matching typography, the Colab-only launcher and the
toolbar accessibility fixes. See #71.

The %%file graph.txt cell moves back inside the exercise: the nested
code-cell kernel defect it was working around (theme#117) shipped in
v2.3.1, and the workaround's own comment said to revert it then.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 7, 2026 00:19
@netlify

netlify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deploy Preview for beautiful-dodol-cb9543 failed.

Name Link
🔨 Latest commit cf4c2c1
🔍 Latest deploy log https://app.netlify.com/projects/beautiful-dodol-cb9543/deploys/6a9e03219fea66000810374e

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are small, consistent, and keep directive structure/config valid while aligning with the stated upstream theme fix.

Pull request overview

This PR updates the MyST site’s pinned QuantEcon theme to v2.5.0 (to pick up upstream KaTeX asset URL fixes and UI/accessibility improvements) and restores the short_path exercise structure by moving the graph-data %%file graph.txt cell back inside the exercise now that nested code cells are expected to register with the kernel.

Changes:

  • Bump the pinned site.template URL from QuantEcon theme v2.3.0 to v2.5.0.
  • Remove the prior workaround comment and relocate the graph.txt writing code cell back within the short_path exercise block.
File summaries
File Description
lectures/short_path.md Moves the graph-data code-cell back inside the exercise and removes the obsolete workaround note.
lectures/myst.yml Updates the pinned theme template URL to QuantEcon theme v2.5.0.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-72--beautiful-dodol-cb9543.netlify.app (cf4c2c1)

✨ Browse the preview at the URL above.

@mmcky
mmcky merged commit 632cbcd into main Sep 7, 2026
3 of 7 checks passed
@mmcky
mmcky deleted the chore/bump-theme-v2.5.0 branch September 7, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants