QEP-5: record acceptance; QEP-2 v1: good first issue reserves the issue for hands-on work - #34
Merged
Merged
Conversation
…ssue for hands-on work QEP-5 merged in #13 while still carrying `status: Draft`, a state a merged QEP may not be in. This records the outcome in the frontmatter and the header table, and applies the *Amendments to QEP-2* edit the QEP carried for acceptance: the `good first issue` row's **When to use** cell gains the norm-5 reservation, QEP-2 takes `version: 1` and a **Version** row. The yml appendix is unchanged. With the edit applied, the Amendments section is removed from QEP-5; QEP-2's cell links back to it. CI stamps `version: 0` and the hash into QEP-5, the hash into QEP-2, and regenerates the README index at merge. Assisted-by: Claude Code (Claude Fable 5.1) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 14, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
It cleanly applies the acceptance/status sync and the QEP-2 substantive amendment (including versioning) with no inconsistencies found in the updated documents.
Pull request overview
Records the acceptance of QEP-5 and applies its previously-staged amendment to QEP-2 by updating the good first issue label semantics and bumping QEP-2’s version.
Changes:
- Update QEP-5
statusto Accepted in both frontmatter and the in-document header table. - Remove QEP-5’s temporary “Amendments to QEP-2” section now that the amendment is applied.
- Amend QEP-2’s
good first issue“When to use” guidance, and addversion: 1plus a Version row in its header table.
File summaries
| File | Description |
|---|---|
| qeps/qep-0005-code-of-ai-use.md | Records acceptance (frontmatter + header table) and removes the now-stale staged amendments section. |
| qeps/qep-0002-standard-github-labels.md | Applies the good first issue reservation wording and records the substantive amendment via version: 1 + header-table Version row. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mmcky
added a commit
that referenced
this pull request
Sep 14, 2026
…d QEPs (#35) Found while verifying the stamp after #34: QEP-5 merged Accepted with no `version` and a `–` in the index, as QEP-3 did at #29. QEP-1 v3 (§ Automation, and Adoption item 4) says the post-merge stamp writes `version: 0` alongside the hash into any QEP that has left Draft and carries no `version`, and backfills already-merged QEPs with the most recent commit that touched each. AGENTS.md documents that behaviour too. `stamp.mjs` never got the change: it still skips an unversioned QEP with `// v0 — no version to stamp`. **What changes** - `stamp.mjs` stamps every non-Draft QEP that has no `version`: a QEP merged by this push takes this SHA; one already on `main` takes the last non-bot commit that touched it. Changed, versioned QEPs are re-stamped exactly as before. A run that starts from the bot's own `[skip-stamp]` commit treats nothing as changed, so a manual run never re-anchors a QEP to a stamp commit. Drafts are never stamped. - `stamp-version.yml` also fires on `.github/scripts/**` (so this backfill runs when this PR merges) and on `workflow_dispatch`. - A comment in `qeps.mjs` no longer calls an absent `version` an implicit v0. **What the merge will do**, from a local run of the script on `main`: | QEP | Before | After | |---|---|---| | QEP-3 | – | v0 @ `d7b1f24` (#29, its acceptance merge) | | QEP-5 | – | v0 @ `8cdca64` (#34, its acceptance merge) | Nothing in `qeps/` is edited by hand in this PR. QEP-1 and QEP-2 are already stamped and are untouched. A second local run reports nothing to stamp, so the script stays idempotent. **Not in scope:** the "theme's version pill" QEP-1 v3 also names has no implementation in this repo (the site is the stock book-theme), so #22 stays open for that half. `check.mjs` is unchanged: after the backfill no QEP on `main` is unversioned, so its "a first version must be 1" rule only ever meets a hand-written `version` on a new QEP, which AGENTS.md already says to omit. Assisted-by: Claude Code (Claude Fable 5.1) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13, which merged QEP-5 still carrying
status: Draft— a state a merged QEP may not be in (QEP-1 § Lifecycle and statuses). This PR does the two things the acceptance was meant to carry, per the At landing items on #33.QEP-5 → Accepted.
status:in the frontmatter and the Status row in the header table. CI stampsversion: 0andversion-hashat merge and regenerates the README row.QEP-2 v1. The Amendments to QEP-2 section that QEP-5 carried is applied as a file edit: the
good first issuerow's When to use cell gains the norm-5 reservation,version: 1goes into the frontmatter, and a Version row is added to the header table. The yml appendix does not change (name, colour, description are the same), and the label-appendix check passes. This wording was reviewed as part of #13; it is a substantive amendment to QEP-2, so it needs the same second reader as #13 had.The Amendments section is removed from QEP-5. It existed to carry the edit until acceptance (AGENTS.md § Amending an accepted QEP); with the edit landed its future tense would be stale, and QEP-2's cell links back to QEP-5. The squash commit subject records
QEP-2 v1.Local run of
check.mjsandcheck-labels.mjspasses; the README index warning is expected and the post-merge stamp resolves it. Squash and merge.Assisted-by: Claude Code (Claude Fable 5.1)
🤖 Generated with Claude Code