ci: re-pin fixtures to the merged byline demo - #431
Conversation
The previous pin pointed at the fixtures #2 branch head, which was necessary while that PR was red: its self-check builds against the latest released theme, and `translators` did not exist until v0.22.0. It has shipped and the PR is merged, so point at the merge commit. Rewrites the comment to describe the two-step dance generally, since it will catch the next person adding a fixtures demo of a new theme option. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow pins for the quantecon-book-theme-fixtures repository to reference the permanent fixtures #2 merge commit (instead of the temporary branch-head SHA), and rewrites the CI comment to document the general “two-step pin” workflow when fixtures introduce a brand-new theme option.
Changes:
- Re-pin
FIXTURES_SHAin CI to the fixtures #2 merge commit0048d104ed1afa587b824d130e5210dc969713c5. - Re-pin the fallback
FIXTURES_SHAin the snapshot-update workflow to the same merge commit. - Rewrite the explanatory comment in CI to describe the general temporary-branch-head → merge-commit repin process.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/update-snapshots.yml | Updates the fallback fixtures SHA used by the snapshot update workflow. |
| .github/workflows/ci.yml | Updates the fixtures SHA used for visual/preview builds and revises the documentation comment above the pin. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
=======================================
Coverage ? 56.30%
=======================================
Files ? 2
Lines ? 547
Branches ? 0
=======================================
Hits ? 308
Misses ? 239
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎭 Visual Regression Test Results
Details
Skipped testsdesktop-chrome › theme.spec.ts › Visual Regression Tests › prob-matrix - full page screenshot |
Points
FIXTURES_SHAat the fixtures #2 merge commit (0048d10) instead of that PR's branch head.The branch-head pin was deliberate but temporary. The fixtures repo's own self-check installs the latest released theme and builds with
--warningiserror, so it failed with "unsupported theme option 'translators'" until v0.22.0 shipped. Pinning to the branch head let this repo test the demo anyway, since CI here installs the PR's own theme. v0.22.0 is now on PyPI, the fixtures PR is green and merged, so the pin can point somewhere permanent.No baseline churn expected: the squash-merge commit and the branch head have byte-identical trees, verified with
git diff.The comment above the pin is rewritten to describe the two-step dance generally rather than this one instance, since it will catch the next person adding a fixtures demo of a new theme option. Options inherited from pydata_sphinx_theme, such as
announcement, skip it entirely — which is why the banner demo never hit this.🤖 Generated with Claude Code