Skip to content

SiteFooter accepts a className prop but never applies it #232

Description

@mmcky

SiteFooter declares className?: string in its props but never uses it — the outer element composes only its own classes plus the grid, so anything a caller passes is silently dropped.

This is cosmetic today rather than a bug: the sole caller (app/components/PageContent.tsx) does not pass className, so nothing currently misbehaves. It is worth fixing because the prop is a silent no-op waiting for someone to trust it, and because SiteFooter is the only component in the codebase that does this — ProjectFrontmatter, ThemeButton and Search all fold their className into a classNames(...) call as expected.

Noted by Copilot on #221 as a suppressed comment; left out of that PR to avoid an unrelated change on a green branch.

Fix

Either apply the prop:

className={classNames(
  'qe-site-footer col-screen text-qetext-light text-opacity-80 dark:text-qetext-dark-muted subgrid-gap',
  grid,
  className
)}

…or drop className from the signature entirely. SiteFooter is repo-local (added 2025-02-14, and no such component exists in @myst-theme), so there is no upstream shape to stay compatible with and either direction is safe. Applying it is the smaller change and matches the rest of the codebase.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueSelf-contained and friendly to newcomerslow-priorityNice to have, no time pressure

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions