SiteFooter declares className?: string in its props but never uses it — the outer element composes only its own classes plus the grid, so anything a caller passes is silently dropped.
This is cosmetic today rather than a bug: the sole caller (app/components/PageContent.tsx) does not pass className, so nothing currently misbehaves. It is worth fixing because the prop is a silent no-op waiting for someone to trust it, and because SiteFooter is the only component in the codebase that does this — ProjectFrontmatter, ThemeButton and Search all fold their className into a classNames(...) call as expected.
Noted by Copilot on #221 as a suppressed comment; left out of that PR to avoid an unrelated change on a green branch.
Fix
Either apply the prop:
className={classNames(
'qe-site-footer col-screen text-qetext-light text-opacity-80 dark:text-qetext-dark-muted subgrid-gap',
grid,
className
)}
…or drop className from the signature entirely. SiteFooter is repo-local (added 2025-02-14, and no such component exists in @myst-theme), so there is no upstream shape to stay compatible with and either direction is safe. Applying it is the smaller change and matches the rest of the codebase.
🤖 Generated with Claude Code
SiteFooterdeclaresclassName?: stringin its props but never uses it — the outer element composes only its own classes plus the grid, so anything a caller passes is silently dropped.This is cosmetic today rather than a bug: the sole caller (
app/components/PageContent.tsx) does not passclassName, so nothing currently misbehaves. It is worth fixing because the prop is a silent no-op waiting for someone to trust it, and becauseSiteFooteris the only component in the codebase that does this —ProjectFrontmatter,ThemeButtonandSearchall fold theirclassNameinto aclassNames(...)call as expected.Noted by Copilot on #221 as a suppressed comment; left out of that PR to avoid an unrelated change on a green branch.
Fix
Either apply the prop:
…or drop
classNamefrom the signature entirely.SiteFooteris repo-local (added 2025-02-14, and no such component exists in@myst-theme), so there is no upstream shape to stay compatible with and either direction is safe. Applying it is the smaller change and matches the rest of the codebase.🤖 Generated with Claude Code