test: refresh linux mobile-chrome baselines after Source Sans 3 self-hosting - #148
Merged
Merged
Conversation
…hosting The @fontsource-variable build of Source Sans 3 has marginally different glyph metrics from the Google-served static font it replaced in #140, so a couple of lines wrap one word differently at the mobile viewport width and all five linux mobile-chrome snapshots drift past the diff budget. Desktop snapshots are unaffected. #140 never got a visual-regression run before merge: as a PR stacked on fix/relative-css-asset-urls it only triggered the preview job, and the base retarget after #139 merged does not fire a synchronize event. Baselines to be refreshed via /update-snapshots on this PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/update-snapshots |
Contributor
|
Contributor
|
🎭 Refreshed visual baselines in 6b7982c:
|
Contributor
🎭 Visual regression results
Details
Skipped testsmobile-chrome › theme.spec.ts › QuantEcon theme — visual regression › launch-colab |
This was referenced Aug 26, 2026
mmcky
added a commit
that referenced
this pull request
Aug 26, 2026
Move the [Unreleased] entries under ## [2.3.1] - 2026-08-26 with a headline blockquote, add the footer compare link, re-point the [Unreleased] compare base at v2.3.1, and bump package.json (npm version 2.3.1 --no-git-tag-version). template.yml is stamped by release.yml at build time. Two accuracy corrections ride along: - The #131 changelog entry claimed the visual suite passes against untouched baselines. That was true when written, but the @fontsource glyph metrics re-wrapped a line at the mobile viewport and #148 had to refresh the linux mobile-chrome baselines. The entry now says so. - PLAN.md open question 4 still named #117 as an open defect gating the cutover. It is fixed and ships here, as does #138. The paragraph now points at the live gate items and at the tracking issue #147. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main went red at the #140 squash-merge: all five linux mobile-chrome snapshots (intro, features, lists, notebook, history-open) now exceed the diff budget, while every desktop snapshot passes.
Cause is benign and verified against the run-32788889406 artifacts: the @fontsource-variable build of Source Sans 3 has marginally different glyph metrics from the Google-served static font it replaced, so at the mobile viewport width a couple of lines wrap one word differently (e.g. the intro fixture's "Here is a link" sentence) and every text pixel shifts. Actual and expected both render Source Sans — the font loads correctly; this is metric drift, not a fallback.
Why #140's CI did not catch it: as a PR stacked on
fix/relative-css-asset-urlsit only triggered the preview job (ci.ymlruns onpull_request: branches: [main]), and GitHub's base retarget after #139 merged fires aneditedevent, notsynchronize, so the full suite never ran before merge.This PR refreshes the linux mobile-chrome baselines via
/update-snapshots. The darwin (local) mobile baselines will need the same refresh on the next local run — flagged for whoever runs the suite locally first.🤖 Generated with Claude Code