Read the six folded datasets from data-lectures, not high_dim_data - #53
Merged
Merged
Conversation
Seven reads across four files. The six datasets moved into QuantEcon/data-lectures (dl#62), so every read follows them -- and the HOST changes too, not just the org and repo. media.githubusercontent.com is the LFS *media* endpoint and routes per path by LFS status. These six were LFS-tracked in high_dim_data and are plain git in data-lectures, so the media host 404s for all of them. Measured: the media URL for data-lectures returns 404 with 0 bytes, the raw URL returns 200. A mechanical org/repo swap preserving the host would have broken every chart in these three lectures. All seven land on raw.githubusercontent.com, including any that used the github.com/*/raw/ redirect form and would have survived a bare org swap. One spelling across all four consuming repos is deliberate: the set 1/2 repoints broke lecture-wasm by "harmonising" its URLs onto the redirect form, whose 302 carries an empty access-control-allow-origin and so is rejected by the browser before it is followed (dl#46). If every repo spells these lines the same way, that class of fix cannot recur. _static/lecture_specific/inequality/data.ipynb is edited by hand. No audit scans _static/**, the build never executes it, and the translation sync is .md-only -- so nothing mechanical would ever carry this change. It is also served: it returns 200 on the published site with the URL in its body. No prose is touched. The lecture's claim that the Forbes billionaires data is a 2020 snapshot is contradicted by the bytes (282 timestamps spanning 2020-04-07 to 2023-04-15, and the chart plots realTimeWorth rather than the annual list), but that is content, not a repoint -- split out to QuantEcon/workspace-lectures#35. The Global 2000 "2020" claim nearby IS correct and is deliberately left alone. Verified: both acceptance greps clean (no media-host data-lectures read, no high_dim_data reference anywhere in lectures/); all 7 URLs return 200; three-way byte identity on the four cross_section files -- manifest sha256 = new URL = old high_dim_data URL, so this changes the address and not the data. Part of QuantEcon/workspace-lectures#23. Data: QuantEcon/data-lectures#62 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this repo’s lecture notebooks to read the six “folded” datasets from their new home in QuantEcon/data-lectures, using the correct raw.githubusercontent.com host so the data loads correctly now that the files are plain git (not LFS).
Changes:
- Repoint SCF-derived CSV reads in
mle.mdandinequality.mdfromQuantEcon/high_dim_datatoQuantEcon/data-lecturesonraw.githubusercontent.com. - Repoint four
cross_sectionCSV reads inheavy_tails.mdfrom the LFS media endpoint toraw.githubusercontent.com/QuantEcon/data-lectures. - Update the matching URL embedded in the static
inequality/data.ipynbnotebook.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lectures/mle.md | Updates SCF_plus CSV URL to QuantEcon/data-lectures via raw.githubusercontent.com. |
| lectures/inequality.md | Updates SCF_plus CSV URL to QuantEcon/data-lectures via raw.githubusercontent.com. |
| lectures/heavy_tails.md | Updates four CSV URLs (Forbes + city population) to QuantEcon/data-lectures via raw.githubusercontent.com. |
| lectures/_static/lecture_specific/inequality/data.ipynb | Updates the embedded SCF_plus CSV URL to QuantEcon/data-lectures via raw.githubusercontent.com. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📖 Netlify Preview Ready!Preview URL: https://pr-53--jade-tarsier-d98a19.netlify.app Commit: Build Info
|
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven reads across four files. The six datasets moved into
QuantEcon/data-lectures(QuantEcon/data-lectures#62), so every read here follows them — and the host changes too, not just the org and repo.This repo is the
quantecon/actionscanary. It builds and publishes its own Pages site from a copy of intro's lectures, so its data reads are live reads by real readers, not fixtures.Why the host has to change
media.githubusercontent.comis the LFS media endpoint and routes per path by LFS status. These six were LFS-tracked inhigh_dim_dataand are plain git indata-lectures, so the media host 404s for every one of them — measured: 404 with 0 bytes, against 200 for the raw URL. A mechanical org/repo swap preserving the host would have broken every chart in these three lectures. Repoint rule 6.All seven land on
raw.githubusercontent.com, matchinglecture-python-intro,lecture-wasmandlecture-intro.zh-cnexactly.qeld(QuantEcon/data-lectures#65) is intended to make the spelling an implementation detail later.Nothing automated can see any of this
This repo is not in the data audit's
SCAN_REPOS— it is not a Python-family repo and was never in scope — and it has nodata-url-guard. So unlike intro and wasm, no check of any kind covers these seven reads. Verified by hand:data-lecturesread, and nohigh_dim_datareference anywhere inlectures/cross_sectionfiles — manifestsha256= new URL = oldhigh_dim_dataURL_static/lecture_specific/inequality/data.ipynb:37is edited by hand — no audit scans_static/**, the build never executes it, and it is served with the URL in its body from this repo's own Pages site.What this PR does NOT fix
This repo also holds 14 references to
QuantEcon/lecture-python-intro— reads of intro's committed dataset copies, which intro deleted during repoint sets 1–3. Those are serving 404s today and are out of scope here; they are tracked in QuantEcon/workspace-lectures#28. This PR only clears thehigh_dim_datareads, which were the ones still working and about to stop.No prose is touched
The lecture's claim that the Forbes billionaires data is a 2020 snapshot is contradicted by the bytes (282 timestamps spanning 2020-04-07 to 2023-04-15, and the chart plots
realTimeWorthrather than the annual list). Split out to QuantEcon/workspace-lectures#35. The Global 2000 "2020" claim nearby is correct and is left alone.Part of QuantEcon/workspace-lectures#23 (step 3, PR set C2). Companion PRs land in
lecture-python-introandlecture-wasmunder the same title. Merged as three independent branches offmain, never stacked.🤖 Generated with Claude Code