Repoint the sets 1-3 dataset URLs, which have been serving 404s - #54
Merged
Merged
Conversation
This repo publishes its own Pages site from a copy of intro's lectures
and reads six dataset files from intro by URL. Repoint sets 1-3 deleted
those files from intro after migrating them to data-lectures, and the
pre-deletion sweep was described as org-wide when it covered nine clones
-- so these reads have been dead since. Measured before this change: 7
of the URLs return 404.
Ten lines across three lectures:
french_rev.md:60-62 prose links to blob/main/.../datasets/
french_rev.md:70-71 the base_url continuation -- the read that
actually dies, and easy to miss because
neither line carries a filename
inflation_history.md:82 prose link to the datasets directory
inflation_history.md:86, 228, 358
long_run_growth.md:89
All now read data-lectures and all resolve 200, including the three
reconstructed from base_url. Prose links and {download} targets use the
github.com/*/raw/ form deliberately: they are plain navigations, CORS
does not apply, and this repo executes on CPython.
Four references to lecture-python-intro are deliberately LEFT: the
`usa-gini` read at inequality.md:617/620 and the `life-expectancy` pair
at simple_linear_regression.md:411/416. Both files still exist in intro
and both return 200 -- they are the last two Track A datasets, not yet
migrated. They break when intro's copies are deleted, and repointing
them belongs in that step, not this one.
Note this repo builds only five lectures (`only_build_toc_files: true`
since #49), so none of the three files touched here is built. The
breakage was in the served pages and the weekly link checker, never in a
red build.
Addresses the canary half of QuantEcon/workspace-lectures#28 -- see that
issue for the org-wide sweep rule this is evidence for. Its other half
(tom-econ370-2025) is handled separately.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Repoints broken dataset URLs in three lecture Markdown files so notebook reads, {download} targets, and related links resolve again after dataset migration from lecture-python-intro to data-lectures.
Changes:
- Updated remote
read_excelURLs toQuantEcon/data-lecturesfor affected datasets. - Updated related
{download}targets and prose links to match the new dataset location. - Adjusted
base_urlcomposition infrench_rev.mdto point at the new directory layout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lectures/french_rev.md | Repoints three spreadsheet links and the runtime base_url used to construct dataset URLs. |
| lectures/inflation_history.md | Repoints two read_excel URLs plus a {download} target to the new dataset repo/location. |
| lectures/long_run_growth.md | Repoints the Maddison mpd2020.xlsx read to the new dataset repo/location. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
📖 Netlify Preview Ready!Preview URL: https://pr-54--jade-tarsier-d98a19.netlify.app Commit: Build Info
|
Two Copilot findings on the repoint, both about label-vs-target accuracy rather than the URLs themselves. french_rev.md:60-62 -- the labels read `datasets/fig_3.xlsx` while the targets now resolve to `lectures/fig_3.xlsx`. That mismatch was introduced by the repoint: the label was accurate before it, since the published tree here is flat and has no datasets/ directory. Prefix dropped, and the form changed from raw/ to blob/ so the link renders the file page rather than triggering a download -- these are "here is the data" links, not download targets. inflation_history.md:82 -- "a spreadsheet that is hosted on github" linked to a directory listing. Pre-existing rather than introduced, but the line was already being touched. It now points at CATALOG.md, the generated dataset registry, which is the right target for a sentence introducing a data source; the individual spreadsheet is what the code cell below already fetches. GitHub capitalised. Both targets are what lecture-python-intro settled on when it made the same repoint, so this narrows a gap rather than inventing a convention. Note that is a coincidence of the two repos having done the same edit, not a sync: this repo is a drifted snapshot of intro (479 differing lines in french_rev.md alone, including typos intro has since fixed), so "match upstream" is not a rule that can be applied here wholesale. All seven data-lectures URLs across the three files verified 200, and each french_rev label now matches its target filename. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo publishes its own Pages site from a copy of intro's lectures and reads six dataset files from intro by URL. Repoint sets 1–3 deleted those files from intro after migrating them to
data-lectures, and the pre-deletion sweep was described as org-wide when it actually covered nine clones — so these reads have been dead since. Measured before this change: 7 of the URLs return 404.What changed — ten lines across three lectures
french_rev.md:60-62blob/main/lectures/datasets/french_rev.md:70-71base_urlcontinuation — the read that actually dies, and easy to miss because neither line carries a filenameinflation_history.md:82inflation_history.md:86, 228, 358{download}targetlong_run_growth.md:89mpd2020.xlsxreadAll now read
data-lectures, and all resolve 200 — including the three reconstructed at runtime frombase_url, which were checked by assembling them rather than by reading the line.Prose links and
{download}targets use thegithub.com/*/raw/form deliberately: they are plain navigations, CORS does not apply, and this repo executes on CPython. That is the same call made inlecture-wasm, where the one survivinggithub.comreference is likewise a{download}role.Four references are deliberately left pointing at intro
inequality.md:617and:620(usa-gini-nwealth-tincome-lincome.csv) andsimple_linear_regression.md:411and:416(life-expectancy-vs-gdp-per-capita.csv). Both files still exist in intro and both return 200 today — they are the last two Track A datasets and have not been migrated yet.They break at the moment intro's copies are deleted, which is exactly the step this repo has to be repointed ahead of. Doing it now would mean pointing at files that do not exist yet.
This was never a red build
Since #49 trimmed the TOC under
only_build_toc_files: true, this repo builds five lectures and none of the three touched here is among them. The breakage was in the served pages and the weekly link checker — a reader following a link or running the downloadable notebook — never in CI. Worth stating so nobody concludes the canary was masking an action-chain regression.Addresses the canary half of QuantEcon/workspace-lectures#28. Its other half,
tom-econ370-2025, is a dormant course repo being archived and is documented separately rather than fixed.🤖 Generated with Claude Code