feat(effects)!: Improve error messages by passing callee into check_call/synthesize_call

[acl-cqc]

This significantly improves a lot of the error messages for effects violations, and perhaps might be applied to other errors too?

Note that tensor'd functions are gonna have terrible messages both before and after, I haven't got a test of these yet as they are marked experimental, note comment - we'd need significant refactoring to sort that.

BREAKING CHANGE: (guppylang-internals) top-level check_call and synthesize_call methods take a tuple of str | DefId | None to identify the callee

[hugrbot]

This PR contains breaking changes to the public Python API.

Breaking changes summary

guppylang-internals/src/guppylang_internals/tracing/state.py:0: TracingState.__init__(unused_undroppable_objs):
Positional parameter was moved
Details: position: from 5 to 6 (+1)

guppylang-internals/src/guppylang_internals/tracing/state.py:0: TracingState.__init__(max_effects):
Parameter was added as required

guppylang-internals/src/guppylang_internals/definition/overloaded.py:0: OverloadNoMatchError.__init__(max_effects_from):
Parameter was added as required

guppylang-internals/src/guppylang_internals/checker/cfg_checker.py:73: check_cfg(first_modifier_node):
Positional parameter was moved
Details: position: from 6 to 7 (+1)

guppylang-internals/src/guppylang_internals/checker/cfg_checker.py:73: check_cfg(max_effects_from):
Parameter was added as required

guppylang-internals/src/guppylang_internals/checker/cfg_checker.py:247: check_bb(max_effects_from):
Parameter was added as required

guppylang-internals/src/guppylang_internals/checker/expr_checker.py:1391: synthesize_call(func_ty):
Parameter was removed

guppylang-internals/src/guppylang_internals/checker/expr_checker.py:1391: synthesize_call(target):
Parameter was added as required

guppylang-internals/src/guppylang_internals/checker/expr_checker.py:1432: check_call(func_ty):
Parameter was removed

guppylang-internals/src/guppylang_internals/checker/expr_checker.py:1432: check_call(target):
Parameter was added as required

guppylang-internals/src/guppylang_internals/checker/modifier_checker.py:21: check_modified_block(max_effects_from):
Parameter was added as required

[github-actions]

Bencher Report

Branch	acl/check_syn_call_target
Testbed	Linux

Click to view all benchmark results

Benchmark	hugr_bytes	Benchmark Result bytes x 1e3 (Result Δ%)	Upper Boundary bytes x 1e3 (Limit %)	hugr_nodes	Benchmark Result nodes (Result Δ%)	Upper Boundary nodes (Limit %)
tests/benchmarks/test_big_array.py::test_big_array_compile	📈 view plot 🚷 view threshold	154.02 x 1e3 (0.00%) Baseline: 154.02 x 1e3	155.56 x 1e3 (99.01%)	📈 view plot 🚷 view threshold	6,630.00 (0.00%) Baseline: 6,630.00	6,696.30 (99.01%)
tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile	📈 view plot 🚷 view threshold	27.71 x 1e3 (0.00%) Baseline: 27.71 x 1e3	27.99 x 1e3 (99.01%)	📈 view plot 🚷 view threshold	1,051.00 (0.00%) Baseline: 1,051.00	1,061.51 (99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile	📈 view plot 🚷 view threshold	10.09 x 1e3 (+0.01%) Baseline: 10.09 x 1e3	10.19 x 1e3 (99.02%)	📈 view plot 🚷 view threshold	301.00 (0.00%) Baseline: 301.00	304.01 (99.01%)
tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile	📈 view plot 🚷 view threshold	13.70 x 1e3 (0.00%) Baseline: 13.70 x 1e3	13.83 x 1e3 (99.01%)	📈 view plot 🚷 view threshold	420.00 (0.00%) Baseline: 420.00	424.20 (99.01%)

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

❌ Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (effects@708e4e5). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...ls/src/guppylang_internals/checker/expr_checker.py	83.33%	4 Missing ⚠️
...s/src/guppylang_internals/std/_internal/checker.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             effects    #1846   +/-   ##
==========================================
  Coverage           ?   92.85%           
==========================================
  Files              ?      148           
  Lines              ?    13993           
  Branches           ?        0           
==========================================
  Hits               ?    12993           
  Misses             ?     1000           
  Partials           ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[codspeed-hq]

Merging this PR will degrade performance by 15.11%

❌ 1 regressed benchmark
✅ 10 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌	test_circuit_comptime_compile	1.4 s	1.7 s	-15.11%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing acl/check_syn_call_target (e285257) with main (3c19192)¹}

Footnotes

1. No successful run was found on effects (708e4e5) during the generation of this report, so main (3c19192) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[tatiana-s]

In my opinion it would be better to have a class instead of tuples for readability - especially given the call graph will just store this information instead of using it here directly so this would also simplify the type of the graph

[acl-cqc]

No problem with making this a class, but is it the same as the kind of "node" in the callgraph? Might you want all callgraph nodes to have concrete DefIds, as only such could have outgoing edges?

[acl-cqc]

Turned into extra parameter!