Acl/order effects#1883
Draft
acl-cqc wants to merge 25 commits into
Draft
Conversation
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## effects #1883 +/- ##
==========================================
Coverage ? 92.92%
==========================================
Files ? 149
Lines ? 14026
Branches ? 0
==========================================
Hits ? 13034
Misses ? 992
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
70e627e to
4db2d47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is into the effects branch, i.e. based off #1723; needs reworking to go onto
main.OpWithEffects = Pure | (Op, Sequence[Effect]), update uses everywhere_last_side_effectnow a map from Effect, propagate_side_effects takes list of Effect tooarr[3]i.e.array.__getitem__) is not permitted in pure functions - this may change as part of Define all known effects, update guppy funcs/@hugr_op's #1747.Need to add some tests that actually show things (in particular function calls) being wired up with parallel Order edges rather than sequential, both for pure functions, and for functions with different (nonzero) effects - the latter will probably require "cheating" and passing a non-Effect in (with typechecking turned off)...
Current typedef of
OpWithEffectsas a union is introduced in c4e0124, before that 'twas a class - felt a bit awkward, but suggestions welcome for better ways. (I wanted to make every add_op an error unless updated; given that's now the case, could make add_op take a hugr ExtOp or a tuple, but not sure that's good, an easy mistake to make)