Skip to content

Add example notebook for braket setup and simple circuit#61

Closed
dbcq wants to merge 6 commits into
Quantinuum:mainfrom
dbcq:develop
Closed

Add example notebook for braket setup and simple circuit#61
dbcq wants to merge 6 commits into
Quantinuum:mainfrom
dbcq:develop

Conversation

@dbcq

@dbcq dbcq commented Feb 15, 2023

Copy link
Copy Markdown

Amazon braket documentation is sometimes not very clear, and pytket-braket doesn't have as much documentation as some other pytket extensions. This notebook is based on a Confluence page I wrote for our team and on a notebook by Callum. I have used the notebook template and generation from pytket-quantinuum.

@dbcq dbcq requested a review from cqc-alec as a code owner February 15, 2023 17:45

@cqc-alec cqc-alec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a good idea!

There is a minor formatting issue that should be solved by running the black formatter on the new python file.

Apart from that, I think the instructions should be modified so that the user doesn't create their own plaintext credentials file -- see comment. With the AWS method one doesn't have to explicitly pass in this file. Unless there are some use cases where that doesn't work?

Comment thread examples/python/braket.py Outdated
Comment thread examples/python/braket.py Outdated
@dbcq

dbcq commented Feb 17, 2023

Copy link
Copy Markdown
Author

Could you advise what to do about the failed linting? I assume it comes from the long 'comments' which are turned into markdown cells by p2j. pytket-quantinuum seems to have the same formatting but appears to lint fine, but I couldn't see any particular options which were being used there

@cqc-alec

Copy link
Copy Markdown
Collaborator

Could you advise what to do about the failed linting? I assume it comes from the long 'comments' which are turned into markdown cells by p2j. pytket-quantinuum seems to have the same formatting but appears to lint fine, but I couldn't see any particular options which were being used there

Yes it seems to be coming from the long lines. Can you wrap the lines at 80 characters. or does that break the p2j conversion? If necessary we can exclude the folder from the link check.

@dbcq

dbcq commented Feb 17, 2023

Copy link
Copy Markdown
Author

Yes, p2j treats each line break as a new markdown cell so it doesn't look the best. I assume in pytket-quantinuum they're simply excluded from the linting check

@cqc-alec

Copy link
Copy Markdown
Collaborator

Yes, p2j treats each line break as a new markdown cell so it doesn't look the best. I assume in pytket-quantinuum they're simply excluded from the linting check

Actually they are not excluded there, and the python files do contain long lines (e.g. https://github.com/CQCL/pytket-quantinuum/blob/develop/examples/python/Quantinuum_circuit_submissions.py ), so I am not sure what's different here...

@CalMacCQ

Copy link
Copy Markdown
Contributor

I think it'd be nice to have an example as some of the syntax for pytket-braket can be confusing. Should we finish this off?

@cqc-alec

Copy link
Copy Markdown
Collaborator

I think it'd be nice to have an example as some of the syntax for pytket-braket can be confusing. Should we finish this off?

Sure, I think it's just some linting issues to fix?

@cqc-alec

cqc-alec commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

Please rebase and retarget to main which is now the default branch.

@cqc-melf cqc-melf changed the base branch from develop to main May 13, 2025 11:17
@cqc-melf

Copy link
Copy Markdown
Collaborator

Is this something we are still working on or should we close this?

@CalMacCQ

CalMacCQ commented May 13, 2025

Copy link
Copy Markdown
Contributor

Not working on this but it could be good to add an example.

Any thoughts on this @yoshi-qc ? I sent you both an old example I had lying around.

@cqc-melf

cqc-melf commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

Replaced by #184
Please reopen if I missed anything.

@cqc-melf cqc-melf closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants