Add example notebook for braket setup and simple circuit#61
Conversation
cqc-alec
left a comment
There was a problem hiding this comment.
Thanks, this is a good idea!
There is a minor formatting issue that should be solved by running the black formatter on the new python file.
Apart from that, I think the instructions should be modified so that the user doesn't create their own plaintext credentials file -- see comment. With the AWS method one doesn't have to explicitly pass in this file. Unless there are some use cases where that doesn't work?
|
Could you advise what to do about the failed linting? I assume it comes from the long 'comments' which are turned into markdown cells by |
Yes it seems to be coming from the long lines. Can you wrap the lines at 80 characters. or does that break the p2j conversion? If necessary we can exclude the folder from the link check. |
|
Yes, |
Actually they are not excluded there, and the python files do contain long lines (e.g. https://github.com/CQCL/pytket-quantinuum/blob/develop/examples/python/Quantinuum_circuit_submissions.py ), so I am not sure what's different here... |
|
I think it'd be nice to have an example as some of the syntax for pytket-braket can be confusing. Should we finish this off? |
Sure, I think it's just some linting issues to fix? |
|
Please rebase and retarget to |
|
Is this something we are still working on or should we close this? |
|
Not working on this but it could be good to add an example. Any thoughts on this @yoshi-qc ? I sent you both an old example I had lying around. |
|
Replaced by #184 |
Amazon braket documentation is sometimes not very clear, and
pytket-braketdoesn't have as much documentation as some otherpytketextensions. This notebook is based on a Confluence page I wrote for our team and on a notebook by Callum. I have used the notebook template and generation frompytket-quantinuum.