V0.8 css patch#71
Open
DNA386 wants to merge 4 commits into
Open
Conversation
cqc-melf
previously approved these changes
Aug 5, 2024
cqc-melf
left a comment
There was a problem hiding this comment.
Looks good, sounds like a good plan to do the release from this branch.
cqc-melf
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should allow the v0.8.2 css files to be forward-compatible with v0.9.0.
The intention is to keep this PR open for reference, and release from this branch WITHOUT merging into main (as the fix is technically behind main) as v0.8.2.
Included are some test files to check/compare to other versions.
To use them, run
npm build-libThen you need to serve the built files locally
serve .http://localhost:3000/test/ shows the the new v0.8 will look like
http://localhost:3000/test/test-bugfix shows the expected fixed version of pytket (ie using v0.9 components with v0.8 css)
http://localhost:3000/test/v0-8 shows the previous v0.8