Skip to content

NRP-3193 Multiselect#124

Open
stavros-tomas wants to merge 51 commits into
mainfrom
NRP-3193-multiselect
Open

NRP-3193 Multiselect#124
stavros-tomas wants to merge 51 commits into
mainfrom
NRP-3193-multiselect

Conversation

@stavros-tomas

@stavros-tomas stavros-tomas commented May 22, 2026

Copy link
Copy Markdown
Collaborator

In this PR

  • Introducing a new custom component called <MultiSelect> . You can check the Storybook Preview to check what it can do and what it looks like.
  • Introduce unit testing in Velum with Vitest and RTL and and the relevant tests for the component
  • I am amending the CI to include a storybook preview with Chromatic
  • Also CI changes to trigger unit test run with new commits

@github-actions

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-awbjjfkjke.chromatic.com/

@github-actions

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-blvddpbjlo.chromatic.com/

@github-actions

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-zpoayvwxci.chromatic.com/

@stavros-tomas stavros-tomas marked this pull request as ready for review May 22, 2026 18:18
Comment thread src/custom/multi-select/multi-select.test.tsx Outdated
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-eqzkhsspnd.chromatic.com/

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-ecoznbhyat.chromatic.com/

@github-actions

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-qpsgwsychn.chromatic.com/

@aidanCQ aidanCQ self-assigned this Jun 15, 2026
Comment thread .github/workflows/chromatic.yml Outdated
Comment thread .github/workflows/chromatic.yml Outdated
Comment thread .github/workflows/chromatic.yml
Comment thread src/custom/multi-select/multi-select.stories.tsx
Comment thread package-lock.json Outdated
Comment thread pnpm-workspace.yaml
@github-actions

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-zbaoxvlhrk.chromatic.com/

@github-actions

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-sylzzgfwfp.chromatic.com/

@aidanCQ

aidanCQ commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

A few visual change suggestions

figma
Screenshot 2026-06-17 at 4 18 20 pm

storybook
Screenshot 2026-06-17 at 4 18 59 pm

@github-actions

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-ifyybrrexe.chromatic.com/

@AnnaAbdulova

Copy link
Copy Markdown
Collaborator

There is a checkbox component in storybook that looks slightly different than in the multiselect dropdown - black border and some shadows, could it be reused?

multiselect
image

checkbox
image

@AnnaAbdulova

Copy link
Copy Markdown
Collaborator

I've updated the chip background colour to 0°, 0%, 90% following the feedback, so on hover it is still visible

current multiselect
image

Figma
image

@github-actions

Copy link
Copy Markdown

📚 Storybook Preview: https://63237d0bc757b3509cd96e0e-xofliekoxz.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants