Skip to content

chore(ci): pin audit and supply-chain Actions to commit SHAs - #223

Closed
cryptoxdog wants to merge 1 commit into
mainfrom
feat/pin-gha-workflow-shas
Closed

chore(ci): pin audit and supply-chain Actions to commit SHAs#223
cryptoxdog wants to merge 1 commit into
mainfrom
feat/pin-gha-workflow-shas

Conversation

@cryptoxdog

Copy link
Copy Markdown
Collaborator

Summary

  • Pin mutable GitHub Actions tags in .github/workflows/audit.yml and .github/workflows/supply-chain.yml to full 40-character commit SHAs (CWE-1357 / CWE-353).
  • Scope is commit ebdf066 only. No .claude/, AGENTS.md, CLAUDE.md, or Makefile changes.

Test plan

  • Confirm each uses: in the two workflows is owner/action@<40-hex> with a version comment
  • Confirm already-pinned steps (scorecard-action, dependency-review-action, sbom-action) are unchanged
  • CI on this PR: audit + supply-chain jobs start with the pinned SHAs

Made with Cursor

Mutable v-tags can be retargeted; pin checkout, setup-python, upload-artifact, github-script, and codeql upload-sarif to the current tag commits.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud

Copy link
Copy Markdown

@claude

claude Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Closing as superseded by #221 (merged as b6ab268).

Every SHA this PR proposes is already on main, byte-identical:

action this PR current main
actions/checkout d23441a… d23441a…
actions/setup-python 5fda3b9… 5fda3b9…
actions/upload-artifact 043fb46… 043fb46…
actions/github-script ed59741… ed59741…
codeql-action/upload-sarif db488dd… db488dd…

Diffing this head against origin/main leaves three comment-text differences (# v7.0.1 on main vs # v7 here) and one real regression: merging would delete these lines from .github/workflows/supply-chain.yml, which landed on main after this branch forked:

# SPDX AND compounds in allow-licenses do not match package Dual
# licenses and also break MIT matching (upload-artifact 7.0.1).
allow-dependencies-licenses: pkg:pypi/structlog, pkg:pypi/prometheus-client

That is why the PR shows as conflicting. The pinning objective is already met, so there is nothing left to merge and merging would revert the license-compliance fix. Reopen if I have misread the intent.


Generated by Claude Code

@claude claude Bot closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant