feat(make): proxy PE campaign activation through the CEG Makefile - #226
Conversation
Keep campaign INTENT= on the consumer repo instead of leaving the target sitting uncommitted on dirty main.
|
✅ PR reviewable size is within recommended limits |
L9 Audit Harness Report
Step Results
Architecture Audit Findings
See Spec Coverage
See Next StepsAll checks passed. Safe to merge. |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55e20d2d81
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @$(MAKE) -C "$(HOME)/.cursor-governance" campaign \ | ||
| INTENT="$$(python3 -c 'from pathlib import Path; import sys; print(Path(sys.argv[1]).expanduser().resolve())' "$(INTENT)")" \ | ||
| CAMPAIGN_UNTIL="$(or $(CAMPAIGN_UNTIL),execute)" \ | ||
| CAMPAIGN_ARGS="$(CAMPAIGN_ARGS)" |
There was a problem hiding this comment.
When CAMPAIGN_ARGS contains a double-quoted value with spaces—for example CAMPAIGN_ARGS='--label "hello world"'—Make substitutes it inside this recipe's surrounding double quotes, so the shell splits the result and passes world as an additional target to the recursive Make invocation. The campaign then receives a truncated argument string and fails with No rule to make target 'world'; forward this value without re-parsing it through shell quoting, such as through an exported variable.
Useful? React with 👍 / 👎.
6f46ed7
into
feat/precommit-scoped-pytest-unit
1 participant
Stacked on #224. Adds make campaign INTENT= proxy.