chore(governance): auto-seed org templates from Quantum-L9/.github - #10
chore(governance): auto-seed org templates from Quantum-L9/.github#10cryptoxdog wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f48853d11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| command -v ruff >/dev/null 2>&1 || pip install ruff | ||
| command -v mypy >/dev/null 2>&1 || pip install mypy | ||
| - name: ruff check | ||
| run: ruff check . --output-format=github |
There was a problem hiding this comment.
On every pull request and push, this job runs from the repository root, whereas the existing CI deliberately uses constellation-gate as its working directory. Consequently, ruff check . includes the pre-existing root scripts/validate_sdk_pin.py, which fails with E702 on line 12, and mypy . bypasses the nested pyproject.toml configuration and reports errors throughout tests and scripts. Set the working directory or explicitly scope both commands to the nested project, otherwise this workflow remains red independently of the application changes.
Useful? React with 👍 / 👎.
| env: | ||
| PYTHON_VERSION: "3.12" | ||
| SOURCE_DIR: "." | ||
| TEST_DIR: "tests/" |
There was a problem hiding this comment.
TEST_DIR is resolved from the checkout root, but the repository has no root tests/ directory; its suite is under constellation-gate/tests. Thus every invocation reaches pytest tests/, which exits with code 4 (file or directory not found) before running any tests. Configure the nested path or run this job from constellation-gate.
Useful? React with 👍 / 👎.
| uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0 | ||
| with: | ||
| node-version: ${{ env.NODE_VERSION }} | ||
| cache: ${{ env.PACKAGE_MANAGER }} |
There was a problem hiding this comment.
A repo-wide manifest search finds no package.json or npm lockfile, yet both Node jobs enable setup-node's npm cache. That cache setup requires locating a supported dependency lockfile and fails before the later guards that skip missing tsconfig.json or test scripts, so this newly activated workflow produces failed checks on every pull request and push. Omit or disable the Node template unless a Node project is actually present.
Useful? React with 👍 / 👎.
| update-types: ["minor", "patch"] | ||
|
|
||
| - package-ecosystem: pip | ||
| directory: "/" |
There was a problem hiding this comment.
The actual Python dependency manifest is constellation-gate/pyproject.toml, while the root contains only requirements-ci.txt pointing at that local editable package. Dependabot's pip update directory is not recursive, so configuring / will not update dependencies declared in the nested pyproject.toml, including FastAPI, Pydantic, and HTTPX. Set this directory to /constellation-gate.
Useful? React with 👍 / 👎.
170b366 to
f3cdfb2
Compare
0c4ba16 to
bed0632
Compare
bed0632 to
db3c45d
Compare
|
1 participant
Automatically seeds org template files from
Quantum-L9/.github/templates/plus thel9-ci-pack/Core hub.Files in this PR
.github/dependabot.yml.github/workflows/governance.yml.github/labels.ymlCODE_OF_CONDUCT.mdCONTRIBUTING.mdSECURITY.mdSUPPORT.md.github/FUNDING.yml.github/ISSUE_TEMPLATE/1-bug.yml.github/ISSUE_TEMPLATE/2-feature.yml.github/ISSUE_TEMPLATE/3-task.yml.github/ISSUE_TEMPLATE/4-incident.yml.github/ISSUE_TEMPLATE/bug_report.yml.github/ISSUE_TEMPLATE/ci-failure.yml.github/ISSUE_TEMPLATE/config.yml.github/ISSUE_TEMPLATE/feature_request.yml.github/ISSUE_TEMPLATE/gov-violation.yml.github/pull_request_template.md.github/workflows/on-org-update.yml.github/workflows/l9-analysis.yml.github/workflows/l9-lint-test-node.yml.github/workflows/l9-lint-test.yml.github/governance/execution-profiles.yaml.github/governance/promotion-policy.yaml.github/governance/provider-requiredness.yaml.github/governance/quality-thresholds.yaml.github/governance/rule-modes.yaml.github/governance/waivers.yamlbiome.json.biomeignore.editorconfig.vscode/extensions.jsonExisting files were left untouched (missing-only seed), except a stock ESLint
l9-lint-test-node.ymlwhich is replaced with the Biome SDK caller.Governance caller is advisory (
strictdefaults false).Core pack callers are distributed here;
l9-ci-coreexecutes CI.Opened automatically by Quantum-L9/.github auto-seed.