chore(governance): auto-seed org templates from Quantum-L9/.github - #37
chore(governance): auto-seed org templates from Quantum-L9/.github#37cryptoxdog wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f272a4dd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| REPOSITORY NOTICE: This LICENSE applies only to the Quantum-L9/.github | ||
| repository. GitHub does not propagate LICENSE files via org community-health | ||
| fallbacks. Other Quantum-L9 repositories should include their own LICENSE | ||
| file (this text may be used as the org template). |
There was a problem hiding this comment.
Remove the repository-excluding license notice
This file is being added to l9-codegraph, but the notice explicitly limits the license to Quantum-L9/.github. As a result, users of this repository are told that none of the preceding license terms apply here, leaving the code without the intended license and undermining the proprietary-use restrictions. Replace the repository name or remove this source-repository-specific notice before distributing the license.
Useful? React with 👍 / 👎.
| node-version: ${{ env.NODE_VERSION }} | ||
| cache: ${{ env.PACKAGE_MANAGER }} |
There was a problem hiding this comment.
Do not run the Node workflow in this Python-only repository
On every PR and push, both Node jobs reach setup-node with npm caching enabled, but this repository has no package.json, package-lock.json, or other npm dependency lockfile. setup-node therefore cannot resolve the dependency file used for its cache key and fails before the later checks can skip missing TypeScript/tests; the same configuration is repeated in the test job. Remove this seeded Node workflow or condition it on the presence of a Node project and lockfile.
Useful? React with 👍 / 👎.
| * @Quantum-L9/platform | ||
|
|
||
| # Blast-radius paths require cryptoxdog as additional reviewer. | ||
| /.github/ @Quantum-L9/platform @cryptoxdog |
There was a problem hiding this comment.
Require the additional blast-radius reviewer explicitly
When code-owner review is enabled, multiple owners on one CODEOWNERS pattern are alternatives: approval from either @Quantum-L9/platform or @cryptoxdog satisfies the rule. Consequently these entries do not enforce the stated requirement that cryptoxdog be an additional reviewer for blast-radius changes; a platform-team approval alone is sufficient. Enforce the second approval through branch/ruleset configuration or a separate check rather than relying on this owner list.
Useful? React with 👍 / 👎.
| if [ -f scripts/sync_ci_from_pack.py ]; then | ||
| python scripts/sync_ci_from_pack.py | ||
| else | ||
| echo "::notice::No sync_ci_from_pack.py found — skipping" | ||
| exit 0 |
There was a problem hiding this comment.
Provide the sync implementation instead of silently skipping
This repository contains no scripts/sync_ci_from_pack.py anywhere, so every org_template_updated dispatch takes this branch, exits successfully, and never synchronizes or opens a PR. That makes the newly added receiver entirely inert while reporting a successful run. Seed the sync script with the workflow or perform the synchronization directly in this job.
Useful? React with 👍 / 👎.
dc1b228 to
466bc96
Compare
e4bfc54 to
0eca7a6
Compare
0eca7a6 to
5dd66c4
Compare
|
Closing: org auto-seed PR is known-broken (fails CI) and is noise. Do not re-open from the seeder until the template is fixed. |
Automatically seeds org template files from
Quantum-L9/.github/templates/plus thel9-ci-pack/Core hub.Files in this PR
.github/CODEOWNERS.github/workflows/governance.yml.github/labels.ymlCODE_OF_CONDUCT.mdCONTRIBUTING.mdSECURITY.mdSUPPORT.mdLICENSE.github/FUNDING.yml.github/ISSUE_TEMPLATE/1-bug.yml.github/ISSUE_TEMPLATE/2-feature.yml.github/ISSUE_TEMPLATE/3-task.yml.github/ISSUE_TEMPLATE/4-incident.yml.github/ISSUE_TEMPLATE/bug_report.yml.github/ISSUE_TEMPLATE/ci-failure.yml.github/ISSUE_TEMPLATE/config.yml.github/ISSUE_TEMPLATE/feature_request.yml.github/ISSUE_TEMPLATE/gov-violation.yml.github/pull_request_template.md.github/workflows/on-org-update.yml.github/workflows/l9-analysis.yml.github/workflows/l9-lint-test-node.yml.github/workflows/l9-lint-test.yml.github/governance/execution-profiles.yaml.github/governance/promotion-policy.yaml.github/governance/provider-requiredness.yaml.github/governance/quality-thresholds.yaml.github/governance/rule-modes.yaml.github/governance/waivers.yamlbiome.json.biomeignore.editorconfig.vscode/extensions.jsonExisting files were left untouched (missing-only seed), except a stock ESLint
l9-lint-test-node.ymlwhich is replaced with the Biome SDK caller.Governance caller is advisory (
strictdefaults false).Core pack callers are distributed here;
l9-ci-coreexecutes CI.Opened automatically by Quantum-L9/.github auto-seed.