chore(governance): auto-seed org templates from Quantum-L9/.github - #32
chore(governance): auto-seed org templates from Quantum-L9/.github#32cryptoxdog wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac36405fe4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: | | ||
| set -euo pipefail | ||
| case "${PACKAGE_MANAGER}" in | ||
| npm) if [ -f package-lock.json ]; then npm ci; else npm install; fi ;; |
There was a problem hiding this comment.
This workflow runs on every pull request and push, but this repository contains no package.json or Node lockfile, so both the typecheck and test jobs reach this branch and fail at npm install; npm 11.4.2 reports ENOENT ... Could not read package.json for this invocation. Gate the jobs on the presence of a Node manifest or do not seed this active Node workflow into this Python-only repository.
Useful? React with 👍 / 👎.
| # ── Consumer config: edit these values for your repo ─────────────────────────── | ||
| env: | ||
| PYTHON_VERSION: "3.12" | ||
| SOURCE_DIR: "." |
There was a problem hiding this comment.
Passing SOURCE_DIR="." as mypy's positional target overrides the existing pyproject.toml scope of src and tests and pulls the intentionally excluded legacy runtime/ scripts into strict checking. Running the workflow's command against this commit reports 64 errors in 21 files, so the newly enabled lint job fails every pull request even though the repository's established mypy gate is scoped correctly; set this to the actual typed sources or omit the positional target.
Useful? React with 👍 / 👎.
| if [ -f scripts/sync_ci_from_pack.py ]; then | ||
| python scripts/sync_ci_from_pack.py | ||
| else | ||
| echo "::notice::No sync_ci_from_pack.py found — skipping" | ||
| exit 0 |
There was a problem hiding this comment.
In the reviewed commit, a repo-wide search finds scripts/sync_ci_from_pack.py only in this conditional and no implementation is present, so every org_template_updated dispatch exits successfully without syncing anything or opening a PR. This silently defeats the workflow's stated auto-sync purpose and allows governance templates to drift; seed the script with the receiver or make the workflow fetch and execute the centrally maintained implementation.
Useful? React with 👍 / 👎.
| REPOSITORY NOTICE: This LICENSE applies only to the Quantum-L9/.github | ||
| repository. GitHub does not propagate LICENSE files via org community-health | ||
| fallbacks. Other Quantum-L9 repositories should include their own LICENSE | ||
| file (this text may be used as the org template). |
There was a problem hiding this comment.
The newly added LICENSE is installed in l9-cognitive-runtime, but this notice expressly says it applies only to the separate Quantum-L9/.github repository and directs other repositories to include their own license. That disclaims the preceding limited grant for the code actually being distributed here, leaving users without a coherent repository license; replace this source-template notice with wording naming the current repository.
Useful? React with 👍 / 👎.
6c20a76 to
24a7000
Compare
24a7000 to
0ed186a
Compare
|
1 participant
Automatically seeds org template files from
Quantum-L9/.github/templates/plus thel9-ci-pack/Core hub.Files in this PR
.github/CODEOWNERS.github/dependabot.yml.github/workflows/governance.yml.github/labels.ymlCODE_OF_CONDUCT.mdCONTRIBUTING.mdSECURITY.mdSUPPORT.mdLICENSE.github/FUNDING.yml.github/ISSUE_TEMPLATE/1-bug.yml.github/ISSUE_TEMPLATE/2-feature.yml.github/ISSUE_TEMPLATE/3-task.yml.github/ISSUE_TEMPLATE/4-incident.yml.github/ISSUE_TEMPLATE/bug_report.yml.github/ISSUE_TEMPLATE/ci-failure.yml.github/ISSUE_TEMPLATE/config.yml.github/ISSUE_TEMPLATE/feature_request.yml.github/ISSUE_TEMPLATE/gov-violation.yml.github/pull_request_template.md.github/workflows/on-org-update.yml.github/workflows/l9-analysis.yml.github/workflows/l9-lint-test-node.yml.github/workflows/l9-lint-test.yml.github/governance/execution-profiles.yaml.github/governance/promotion-policy.yaml.github/governance/provider-requiredness.yaml.github/governance/quality-thresholds.yaml.github/governance/rule-modes.yaml.github/governance/waivers.yamlbiome.json.biomeignore.editorconfig.vscode/extensions.jsonExisting files were left untouched (missing-only seed), except a stock ESLint
l9-lint-test-node.ymlwhich is replaced with the Biome SDK caller.Governance caller is advisory (
strictdefaults false).Core pack callers are distributed here;
l9-ci-coreexecutes CI.Opened automatically by Quantum-L9/.github auto-seed.