Improve code quality#36
Merged
Merged
Conversation
This makes error messages more useful, as it includes the two compared values.
Having a convention for where the expected and actual result should be in the macro makes sense, so one can understand error messages without checking the code. Using the rigth argument for the "right", i.e. correct, value is easy to remember.
This function was stabilized in 1.86.0.
Ectras
force-pushed
the
improve_code_quality
branch
from
f2168f7 to
e8122c5
Compare
keefehuang
approved these changes
Aug 1, 2025
keefehuang
left a comment
keefehuang
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. All changes make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several minor changes to increase the code quality. Pushes the MSRV to 1.86.0 because of
get_disjoint_mut. It's a lot of small commits, I can also squash them.