Skip to content

Rename crate to synir#56

Merged
Ectras merged 1 commit into
mainfrom
51-rename-rust-package-to-synir-because-syn-already-exists-as-a-crate
Sep 17, 2025
Merged

Rename crate to synir#56
Ectras merged 1 commit into
mainfrom
51-rename-rust-package-to-synir-because-syn-already-exists-as-a-crate

Conversation

@Ectras

@Ectras Ectras commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator

This PR changes the name in Cargo.toml and all usages. Note that the crate name can be independent of the folder name (the latter is still "syn" because that's the name of the repository).

Closes #51

@Ectras Ectras linked an issue Sep 8, 2025 that may be closed by this pull request
@Ectras Ectras force-pushed the 51-rename-rust-package-to-synir-because-syn-already-exists-as-a-crate branch from f966876 to 00d461c Compare September 8, 2025 08:44

@y-richie-y y-richie-y left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Cargo.lock
@@ -556,6 +556,17 @@ dependencies = [

[[package]]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use the other syn crate? Or should we remove this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used by some of the dependencies (otherwise, cargo would have removed it from the lockfile). There are a few "syn 2.0.102" -> "syn" changes further below; these are dependencies on the syn crate that, before, used the additional version to discriminate our crate ("syn 0.1.0") from the actual syn ("syn 2.0.102").

@Ectras Ectras merged commit e3d2dd1 into main Sep 17, 2025
2 checks passed
@Ectras Ectras deleted the 51-rename-rust-package-to-synir-because-syn-already-exists-as-a-crate branch September 17, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename rust package to synIR because syn already exists as a crate

2 participants