Merged
Conversation
Collaborator
Author
|
The PR looks solid. It addresses the Android 12+ splash screen limitations by leveraging the Review Summary
ConclusionThe changes are consistent and follow the recommended pattern for handling splash screens on newer Android versions while maintaining support for older ones and iOS. I've reviewed the code and configuration changes, and they look correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android splash was broken, now fixed
Android doesn't allow bg image so it's just plain dark grey
This can only be tested by starting the app from scratch so it's quite annoying to test
iOS still good
Android now good