q-dev: expose device assignment modes - #487
Open
piotrbartman wants to merge 3 commits into
Open
piotrbartman wants to merge 3 commits into
piotrbartman wants to merge 3 commits into
Conversation
Until now, the available assignment modes were hidden in code without an endpoint in the API.
delegate everything not overridden in AppProxy to the wrapped app
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
==========================================
+ Coverage 76.71% 76.79% +0.08%
==========================================
Files 53 53
Lines 9428 9465 +37
==========================================
+ Hits 7233 7269 +36
- Misses 2195 2196 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This makes code even cleaner, since there can be more device classes that cannot be attached manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, the available assignment modes were hidden in code without an endpoint in the API.
requires: QubesOS/qubes-core-admin/pull/857