qvm-device: fix wrappers on Python 3.14 - #500
Open
mickeyslaven wants to merge 1 commit into
Open
mickeyslaven wants to merge 1 commit into
mickeyslaven wants to merge 1 commit into
Conversation
Python 3.14 rejects store_const on positional arguments, preventing qvm-block, qvm-usb, and qvm-pci from constructing their parsers. Use a parser default for the wrapper-provided device class and add a regression test for fixed-class parsers. Fixes QubesOS/qubes-issues#11029
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
+ Coverage 76.85% 76.87% +0.01%
==========================================
Files 53 53
Lines 9438 9438
==========================================
+ Hits 7254 7255 +1
+ Misses 2184 2183 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 rejects store_const on positional arguments, preventing qvm-block, qvm-usb, and qvm-pci from constructing their parsers.
The fix uses a parser default for the wrapper provided device class and add a regression test for fixed-class parsers. This method was suggested by the initial issue contributor.
Fixes QubesOS/qubes-issues#11029
AI DISCLOSURE: Generative Ai was utilized in testing, writing, and assisting in review of this code. I signed and personally reviewed the code myself and take responsibility for its contents.