Conversation
This makes the testname unambiguously parsable. Signed-off-by: Glenn Washburn <development@efficientek.com>
Send the --filename= argument to fio instead of having the test file be hardcoded in the fio config file. This removes the need to change to the directory to be on the volume to be tested. Signed-off-by: Glenn Washburn <development@efficientek.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 70.75% 70.72% -0.04%
==========================================
Files 61 61
Lines 14456 14456
==========================================
- Hits 10229 10224 -5
- Misses 4227 4232 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
crass
force-pushed
the
improve-storage-perf
branch
from
September 16, 2026 21:46
3424d97 to
220f6fd
Compare
Member
There is a bot posting results on github: But looks like it should be okay with that separator change. |
…lume Create a subclass of TestRun to named TestRunVolume to handle test runs specific to volumes. Signed-off-by: Glenn Washburn <development@efficientek.com>
Create another subclass of TestRun, called TestRunDevice, and change argument parsing to not take a --device argument, which is mutually exclusive with --volume. It can also take a --mount option to have the block device mounted and the performance testing some on that mount. Signed-off-by: Glenn Washburn <development@efficientek.com>
crass
force-pushed
the
improve-storage-perf
branch
from
September 16, 2026 22:58
220f6fd to
0b59d65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors
storage_perf.pyand add the--deviceoption for testing a given block device, either in dom0 or in the VM. There is an optional--mountoption to mount and do the test on the mount of the block device.This is backwards compatible with the previous usage, so existing usages should see no change. The one except is in the creation of the name prefix where the '_' separator was replaced with ':' to improve parseability. I doubt anything has been parsing that though.