device busy attribute to prevent attaching devices whose children are in use - #144
Open
piotrbartman wants to merge 4 commits into
Open
piotrbartman wants to merge 4 commits into
piotrbartman wants to merge 4 commits into
Conversation
…tries previous udev script just deleted the parent entry when a partition was busy we keep this behavior for local use the "busy marker" is propagated to USB parent
if one of subdevices are locally used (e.g. in sys-usb) the parent is considered busy.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 71.24% 71.27% +0.02%
==========================================
Files 6 6
Lines 991 992 +1
==========================================
+ Hits 706 707 +1
Misses 285 285 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 18, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026071723-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests22 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 25 fixed
Unstable testsDetails
Performance TestsPerformance degradation:19 performance degradations
Remaining performance tests:91 tests
|
A device that is used (mounted etc.) locally by backend VM must not be handed to another one. This exposes them as a `used` ones. The marker means that the device, or it's child in use *locally*. Based on this marker and current attachment we discover if device is `busy`. Only backend VM writes to QubesDB and only about internal state. For this reason `busy` was renamed to `used` in QubesDB path. Mounting generates no block uevent, so qubes-block-mount-watcher polls the mount table and re-triggers the affected devices. `/qubes-device-usage-tracking` tells if a qube reports usage. `udev-qubes-vbd` handles detach `qubes.RefreshBlockDevices` handles attach
for different drivers previous solution does not work and we end up with garbage in qubesDB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
busyattribute handling so a device that's in use (attached or used locally) stays visible in QubesDB with a busy=True marker instead of disappearing entirely, and propagates that marker up to the parent disk and the USB ancestor.xs_mark_busy,xs_mark_usb_busyset busy on the device and on the USB parent.usb_parent_still_in_usescans all sibling devices for either attachment or local use, to decide if the USB busy marker can be cleared.qubes.RefreshBlockDevicesre-triggers udev change events for it and its partitions after detach to force a state refresh from the one place that actually knows the truth (backend's sysfs + mount table), instead of guessing from cache.Open items: