Get attribute from VM object instead of string - #457
Merged
Merged
Conversation
ben-grande
force-pushed
the
remote-boot-exclusion
branch
from
July 27, 2026 09:29
649eaad to
f46fbfd
Compare
ben-grande
marked this pull request as ready for review
July 27, 2026 09:36
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 69.34% 69.31% -0.04%
==========================================
Files 17 17
Lines 4058 4060 +2
==========================================
Hits 2814 2814
- Misses 1244 1246 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ben-grande
force-pushed
the
remote-boot-exclusion
branch
from
July 27, 2026 14:38
f46fbfd to
08144d6
Compare
This was referenced Jul 31, 2026
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026080303-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 23 fixed
Unstable testsDetails
Performance TestsPerformance degradation:18 performance degradations
Remaining performance tests:92 tests
|
This was referenced Jul 31, 2026
marmarek
requested changes
Aug 2, 2026
| QtWidgets.QDialog): | ||
| def __init__(self, vm, qapp, qubesapp=None, *, parent=None, new_vm=False): | ||
| def __init__( | ||
| self, vm: QubesVM, qapp: QtWidgets, *, parent=None, new_vm: bool = False |
Member
There was a problem hiding this comment.
The argument change needs updating all places where it's used. For example, you missed the standalone qubes-vm-boot-from-disk command (and BTW there deviating from standardized arguments makes it problematic...).
Member
There was a problem hiding this comment.
And also, I question type type hints: QtWidgets is a module name, I think you meant QtWidgets.QApplication.
| self.new_vm = new_vm | ||
|
|
||
| if vm.klass in ["RemoteVM", "AdminVM"]: | ||
| if self.vm.klass in ["RemoteVM", "AdminVM"]: |
Member
There was a problem hiding this comment.
Any specific reason for this change (here and below)?
Contributor
Author
There was a problem hiding this comment.
Mostly stylistic choice, that when using a variable that is a class attribute, I prefer using it rather than the parameter.
Contributor
Author
There was a problem hiding this comment.
Also see on line 61, it using self.vm instead of vm...
ben-grande
force-pushed
the
remote-boot-exclusion
branch
from
August 2, 2026 05:11
08144d6 to
cce338e
Compare
In some instances, it uses both methods on "__init__", let's unify to instance attribute.
ben-grande
force-pushed
the
remote-boot-exclusion
branch
from
August 2, 2026 05:15
cce338e to
48e0822
Compare
marmarek
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: QubesOS/qubes-issues#11015