Deferred template - #458
ben-grande wants to merge 5 commits into
Conversation
|
Marta, from all the "deferred template" PRs, I think this one is where most discussion regarding user facing changes will happen. Especially these commits:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026083116-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 34 fixed
Unstable testsDetails
Performance TestsPerformance degradation:19 performance degradations
Remaining performance tests:92 tests
|
d6dd7d9 to
ca37be9
Compare
With a server that supports deferred template, clients don't need to worry about the qube state to block template change, in this case, there were only things to remove, as showing "active_template" is irrelevant here, the user just wants to change the "template" property to a new value. For: QubesOS/qubes-issues#8070 Requires: QubesOS/qubes-core-admin#870 Requires: QubesOS/qubes-core-admin-client#496
There is now two warnings for the template value, but they rely on different labels, as it makes it easier to enable them. On the other hand, I could not make the labels be as close to each other, so the label on the last column is much farther away than what would be considered beautiful.
As the server gained support for deferred template, the client doesn't need to worry about the qube state to block template change.
Some features are relevant for the current running qube, such as seamless mode on Windows, in that case, the client needs to query from the "active_template". In other cases, when it is related to a responsibility that is only gained on the next boot, such as boot mode, the query is made targeting the "template" property.
Ideally, we'd inform with icon plus a text description that the "active_template" is different than the "template" property. For now, only the VM settings does that, but still doesn't show the "active_template", as the labels are controlled by the UI files.
ca37be9 to
735945e
Compare
|
Once this PR is merged, it will unblock: |
The test expected running qubes not having dropdowns, which is no longer the case with deferred templates. I'll adjust it. |
|
Thanks. I see now that I click on the "eye" icon, what the needle was expecting. |
3 participants
For: QubesOS/qubes-issues#8070
Requires: QubesOS/qubes-core-admin-client#496
See individual commits messages.