ci: multi-transport (subprocess/http/unix) SQL E2E + externalize streaming cursors - #2
Merged
Merged
Conversation
… cursors Run the full SQL E2E suite over all three VGI transports (subprocess, http, unix), selected by ci/run-integration.sh's TRANSPORT env var and a CI matrix. - Parameterize run-integration.sh by TRANSPORT; for http/unix start the worker out-of-band and hand the extension a bare URL LOCATION. Inject httpfs on the http leg (the worker-RPC POSTs go through DuckDB's HTTP client). Guard against the runner's silent-skip fake-pass. Keep the mock OData server for all legs. - Wire a --unix flag into the worker main (RunUnix; the SDK had it, the flag was unexposed). - Externalize the streaming table-function cursor: replace the bare `Done bool` emit flag with an explicit gob-encodable Offset cursor and a bounded per-tick emit. Over HTTP the producer state is round-tripped through a continuation token each tick, so a Done flag flipped after Emit re-emits row 0 forever; an advancing Offset survives the boundary and terminates. Add TestCursorSurvivesContinuation (gob round-trip between ticks). All three transports pass locally (subprocess/unix 31 assertions, http 35). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds subprocess/http/unix transport coverage to the SQL E2E suite and fixes the streaming table functions to run over HTTP.
Changes
ci/run-integration.shbyTRANSPORT; CI runs a[subprocess, http, unix]matrix.--unixflag into the worker main (RunUnix).Done boolwith a gob-encodableOffsetcursor + bounded per-tick emit, so producer state survives the HTTP continuation boundary. AddedTestCursorSurvivesContinuation.All three transports pass locally (subprocess/unix 31 assertions, http 35).
🤖 Generated with Claude Code