Skip to content

Conversation

@Quiddlee
Copy link
Owner

  1. Task: click
  2. Screenshot:
    image

image

image

  1. Deploy: click
  2. Done 14.11.2023 / deadline 20.11.2023
  3. Score: 100 / 100

Functional requirements 🍿

  • 📥 Redux is integrated to the app with the help of Redux Toolkit - 25 points
  • 🔍 Search is saved in the store - 5 points
  • 🔢 Items per page is saved in the store - 5 points
  • 🪟 View mode is saved in the store - 10 points
  • 🔃 Loading indicators are shown, loading flags are saved in the store, - 10 points
  • 📞 When either search or items per page is changed, application makes a new call using RTK Query to fetch the data - 25 points
  • 🧪 Tests had been modified to test the functionality using Redux and RTK Query - 20 points

Penalties 👎

  • 😥 TypeScript isn't used: -95 points
  • 😱 Usage of any: -20 points per each
  • 🙀 Usage of ts-ignore: -20 points per each
  • 🧃 Direct DOM manipulations inside the React components: -50 points per each
  • 🪝 React hooks are used to get access to either state, or to the component lifecycle: -70 points
  • 💨 Presence of code-smells (God-object, chunks of duplicate code), commented code sections: -10 points per each
  • 📚 Usage of component libraries, e.g. Material UI, Ant Design: -100 points
  • 📔 Test coverage is less than 80%: -30 points
  • 📛 Commits after the deadline: -40 points

@Quiddlee Quiddlee changed the title Module 04 Module 04 | Redux. RTK. Nov 14, 2023
@Quiddlee Quiddlee changed the base branch from main to module-03 November 14, 2023 08:37
@Quiddlee Quiddlee requested a review from andron13 November 14, 2023 08:54
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

огонь

Comment on lines +10 to +19
/**
* Floating tooltip bubble following the mouse.
* The tooltip is displayed when the element is hovered and follows the mouse movement.
*
* @param {RefObject<LocomotiveScroll>} scroll - The reference to the LocomotiveScroll instance. Used to hide the tooltip on scroll
* @return {Object} obj - An object containing the tooltip reference, hideTooltip function, and showTooltip function.
* @return {HTMLDivElement} obj.tooltipRef - The ref with the tooltip element.
* @return {() => void} obj.hideTooltip - Function that is used to hide the tooltip. For example on mouseLeave event.
* @return {() => void} obj.showTooltip - Function that is used to show the tooltip. For example on mouseEnter event.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

гуд

Copy link
Collaborator

@andron13 andron13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По коду всё гуд, претензий нет.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants