Skip to content

Conversation

@supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Nov 16, 2025

aka 'Fun with data structures'

Adds a "Search menus" menu under the "Help" menu.

Tasks

  • make all current menus searchable (except Help and contents)
  • implement search aliases (search "debug" to find the Dev menu)
  • make all (most ?) current menu items searchable
  • contains string search
  • display search alias next to result
  • make clicking on a search result effectively click the corresponding element
  • hot keys
  • make selecting a search result also select the corresponding element (if swing allows it)
    swing does not allow it; instead, hold shift to select the searched item

Yes, the abstraction behind tries is a 'bit' overkill.
Yes, the generics in CompositeStringMultiTrie* got a little out of hand.
Yes, it was fun to write.

@supersaiyansubtlety supersaiyansubtlety self-assigned this Nov 16, 2025
@supersaiyansubtlety supersaiyansubtlety added enhancement New feature or request user interface affects the enigma ui labels Nov 16, 2025
@supersaiyansubtlety supersaiyansubtlety force-pushed the menu-search branch 2 times, most recently from ea7d7db to fdbfac5 Compare November 18, 2025 23:22
@supersaiyansubtlety supersaiyansubtlety changed the base branch from develop/2.7 to develop/2.8 November 18, 2025 23:22
@supersaiyansubtlety supersaiyansubtlety added the wip in progress label Nov 20, 2025
@supersaiyansubtlety supersaiyansubtlety marked this pull request as ready for review November 23, 2025 22:42
@supersaiyansubtlety supersaiyansubtlety removed the wip in progress label Nov 23, 2025
@supersaiyansubtlety
Copy link
Member Author

ready!

@supersaiyansubtlety
Copy link
Member Author

supersaiyansubtlety commented Dec 27, 2025

I've noticed an issue where menus that require scrolling don't update properly when scrolling.
It occurred even when I completely disabled the SearchMenusMenu and tested on a dummy menu full of 100 plain JMenuItems.

I have occasionally seen the scrolling work, so I'll see if I can fix it consistently.
If not, I'll re-introduce truncation, this time with custom scrolling.

Converting to draft for now.

@supersaiyansubtlety supersaiyansubtlety marked this pull request as draft December 27, 2025 03:42
…t scroll properly when the glass pane is visible and the window is max-height
- it only caused issues when the window's glass pane was visible
- not allowing focus stopped key events to non-FlatLaf LookAndFeels' full-screen-height popup menus
@supersaiyansubtlety
Copy link
Member Author

supersaiyansubtlety commented Dec 29, 2025

I've noticed an issue where menus that require scrolling don't update properly when scrolling.

Fixed/worked around; re-de-drafting.

I just hid the glass pane that notifications are shown in when it's empty.

Menu scrolling is still broken when using flatlafs, the window is full-screen-height, and notifications are showing.
See JFormDesigner/FlatLaf#1071

@supersaiyansubtlety supersaiyansubtlety marked this pull request as ready for review December 29, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request user interface affects the enigma ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant