Skip to content

refactor: extractrefactor: extract buildTransferMessage helper function buildTransferMessage helper function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
issam2021 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: extractrefactor: extract buildTransferMessage helper function buildTransferMessage helper function #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 34 additions & 13 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,34 @@ export class QuipSigner {
return this.wots.sign(key.privateKey, key.publicKey.publicSeed, message);
}
}

/**
* buildTransferMessage constructs the packed message data used for
* transfer signature verification in the QuipWallet contract.
*
* @param currentPqOwner - The current post-quantum owner key pair
* @param nextPublicKey - The next post-quantum public key
* @param to - The recipient address
* @param value - The transfer amount in wei
* @returns The ABI-packed message bytes
*/
function buildTransferMessage(
currentPqOwner: { publicSeed: string; publicKeyHash: string },
nextPublicKey: WinternitzPublicKey,
to: ethers.AddressLike,
value: bigint
): string {
return ethers.solidityPacked(
["bytes32", "bytes32", "bytes32", "bytes32", "address", "uint256"],
[
currentPqOwner.publicSeed,
currentPqOwner.publicKeyHash,
nextPublicKey.publicSeed,
nextPublicKey.publicKeyHash,
to,
value,
]
);
}
export class QuipWalletClient {
private wallet: QuipWallet;
private quipSigner: QuipSigner;
Expand Down Expand Up @@ -156,18 +183,12 @@ export class QuipWalletClient {
const publicSeed = ethers.getBytes(currentPqOwner.publicSeed);
const transferFee = await this.getTransferFee();

// TODO: Make a function that does this?
const packedMessageData = ethers.solidityPacked(
["bytes32", "bytes32", "bytes32", "bytes32", "address", "uint256"],
[
currentPqOwner.publicSeed,
currentPqOwner.publicKeyHash,
nextPqOwner.publicKey.publicSeed,
nextPqOwner.publicKey.publicKeyHash,
to,
value,
]
);
const packedMessageData = buildTransferMessage(
currentPqOwner,
nextPqOwner.publicKey,
to,
value
);

// FIXME: these are stupid in hindsight.
const message = {
Expand Down