Skip to content

implemented E2E-CHAT-008 Chat Search and resolved mobile viewport dra…#407

Merged
motirebuma merged 3 commits into
QuoteVote:mainfrom
sandy4242:main
Jul 5, 2026
Merged

implemented E2E-CHAT-008 Chat Search and resolved mobile viewport dra…#407
motirebuma merged 3 commits into
QuoteVote:mainfrom
sandy4242:main

Conversation

@sandy4242

@sandy4242 sandy4242 commented Jun 30, 2026

Copy link
Copy Markdown
Member
  • Added Playwright end-to-end coverage for searching discussion chats by username and keyword.
  • Introduced data-testid properties for ChatContent, ChatList, ChatSearchInput, and PostChatMessage.
  • Updated ChatList search filtering logic to correctly match discussion keywords.
  • Removed duplicate MobileDrawer component from ChatMenu to resolve overlapping layers on mobile.
  • Prevents immediate drawer self-closure in ChatPanel by preventing default on interact-outside events.
  • Aligeds loginUser token properties in auth client to support token/accessToken responses.

all tests were done using ai and no issues were found

issue reference: #396
@flyblackbox

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

@sandy4242 is attempting to deploy a commit to the Louis Girifalco's projects Team on Vercel.

A member of the Team first needs to authorize it.

@motirebuma motirebuma self-requested a review July 3, 2026 22:36

@motirebuma motirebuma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sandy4242 there's good stuff in here. The ChatList search improvement (matching against postDetails.title and postDetails.text in addition to room title) is a real fix, the duplicate MobileDrawer removal from ChatMenu is a nice cleanup, and the drawer interact-outside prevention makes sense for the chat panel UX. The E2E spec covers the search flow well.

A few things to address before this can land:

  • Remove debug console.logs from ChatList.tsx. You've got console.log('ChatList state:', ...) and console.log('ChatList filteredRooms details:', ...) that shouldn't ship to production. Easy fix.
  • Conflicts with other open PRs. Your ChatSearchInput prevAddBuddyModeRef fix duplicates PR #402 (which is smaller and ready to merge). The SelectionPopover _topOffset rename overlaps with PR #401's full portal rewrite. The Playwright config and jest exclusion conflict with PRs #399 and #405. I'd suggest dropping the SelectionPopover and ChatSearchInput changes from this PR entirely and letting those other PRs handle them -- that way yours can focus on the chat search feature and drawer fix without stepping on anyone's toes.
  • The _topOffset rename -- if you're not using the prop, remove it from the interface rather than prefixing with underscore. But per the above, probably just drop this change since #401 rewrites the whole component anyway.
  • Scope for future PRs: this bundles an E2E test, a search logic fix, a drawer behavior change, a ChatMenu cleanup, a login SSR fix, and auth token handling into one PR. Smaller, focused PRs are easier to review and less likely to conflict. Not a blocker for this one, just something to keep in mind going forward.

Verdict: needs a quick follow-up remove the console.logs and drop the changes that overlap with #401 and #402, then this is good to go.

Thankyou!!

@flyblackbox @sandy4242

@sandy4242

Copy link
Copy Markdown
Member Author

@motirebuma and @flyblackbox

  1. Removed debug console.log statements from ChatList.tsx

  2. Droped SelectionPopover changes (PR Bugfix/issue 384 viewport clamping #401 conflict)

  3. Droped ChatSearchInput ref fixes (PR fix: ChatSearchInput auto clearing on non buddy mode [RC1-026] #402 conflict)

  4. Droped Playwright Config & Jest Config changes (PR feat(e2e): add Playwright post submission test (E2E-POST-001) #399 & feat(auth): implement E2E-AUTH-006 Eyebrow Email Gateway for Registered Users #405 conflict)

all the above conflicts and console logs issues are addressed

@motirebuma motirebuma self-requested a review July 5, 2026 20:48

@motirebuma motirebuma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sandy4242 all issues are addressed as requested, LGTM

@flyblackbox @sandy4242

@motirebuma motirebuma merged commit 1336516 into QuoteVote:main Jul 5, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants