Skip to content

add an event and a thread to detect game start if run from steam - #22

Open
arnesacnussem wants to merge 4 commits into
R4wizard:masterfrom
arnesacnussem:master
Open

add an event and a thread to detect game start if run from steam#22
arnesacnussem wants to merge 4 commits into
R4wizard:masterfrom
arnesacnussem:master

Conversation

@arnesacnussem

@arnesacnussem arnesacnussem commented May 20, 2020

Copy link
Copy Markdown

#7

@arnesacnussem

arnesacnussem commented May 20, 2020

Copy link
Copy Markdown
Author

use a loop to detect if the game start
but start game with extra parmas from steam url require manual confirm.
from default arg, the thread wait 60*100ms for the game to start, don't know if this is good,but it works

btw, there should a dialog that indicate we're waiting for game to start,especially if we want wait unlimite time,and we should do make it wait unlimite time.

@arnesacnussem arnesacnussem changed the title add an event to detect game exit if run from steam add an event to detect game start if run from steam May 20, 2020
@arnesacnussem arnesacnussem changed the title add an event to detect game start if run from steam add an event and a thread to detect game start if run from steam May 20, 2020
@arnesacnussem

Copy link
Copy Markdown
Author

we can delete the '-no_logo_splashes' param when run it from steam to reduce steam's confirmation

@R4wizard

Copy link
Copy Markdown
Owner

@arnesacnussem Thank you for your contributions! I'll hopefully get a chance to review this and #23 over the weekend.

@arnesacnussem

Copy link
Copy Markdown
Author

still something need to change on this, about 8hr after i'll push, then we don't need to wait for timeout.

it use a inifity loop thread to detect if game start, and should make the thread 'single instance'.

remove default '-no_logo_splashes' in LaunchSteam, make the testing thread 'single instance' to remove thread timeout
@arnesacnussem

Copy link
Copy Markdown
Author

@R4wizard i've updated my code,but git push is broken on my computer, so those changes is edited on github webpage, may contains some format issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants