fix: link generation at hierarchy level 1 fix#450
Merged
Conversation
…aths.py). Fix shacl.py to build path elements for SequencePath instead of raising an error.
…was originally thought because there are no nodes other than the focus node we need to retrieve IRIs/curies for at hierarchy level 1, that we do not need to run a query for to get these nodes. In fact, we should be checking for the child node existence, even if they are not part of the link. This change ensures the property paths are checked at all hierarchy levels by removing a conditional check, simplifying the code
recalcitrantsupplant
changed the title
|
🎉 This PR is included in version 4.23.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR removes special logic to not query for link components for hierarchy level one nodeshapes. It was originally thought because there are no nodes other than the focus node we need to retrieve IRIs/curies for at hierarchy level 1, that we do not need to run a query for to get these nodes. In fact, we should be checking for the child node existence, even if they are not part of the link, such that we do not generate unintended links. This change ensures the property paths are checked at all hierarchy levels (not just the current >1) by removing a conditional check, simplifying the code.
PR #448 should be merged first