Fix router stream log field accumulation#115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
SSE stream events reused the normal binding log path, which records each event's protocol summary onto the exchange span. Runtime JSON logging includes the current span fields on each event, so every stream event could add another copy of fields such as
amber_protocol,amber_rpc_kind,amber_request_key, andamber_rpc_id.Validation
cargo fmtcargo test -p amber-router sse_events_do_not_record_per_event_protocol_fields_on_exchange_spancargo clippy --all-targetscargo test --workspace --all-featuresgit diff --checkCloses #113