Add /getswap API#55
Merged
Merged
Conversation
zoedberg
requested changes
May 19, 2025
Member
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
Thanks! I've requested a small change. Please also rebase the commit on top of the latest master (after the recent Rust update there was a lint error), modify the README (as requested in the issue) and edit the swap_roundtrip_assets to use the new API (as requested elsewhere)
Arshia-r-m
force-pushed
the
add-getswap-api
branch
from
0d4d94a to
a818f2c
Compare
Contributor
Author
|
The changes has been made |
zoedberg
requested changes
May 20, 2025
Member
zoedberg
left a comment
zoedberg
left a comment
There was a problem hiding this comment.
I've requested a small change. Also it seems you forgot to rebase on the latest master, please do that and also rename the commit to add /getswap API
Arshia-r-m
force-pushed
the
add-getswap-api
branch
from
05496d8 to
746fb00
Compare
Arshia-r-m
force-pushed
the
add-getswap-api
branch
from
746fb00 to
5c870ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add /getswap API to get a single swap via it's payment hash
fix to #54