Skip to content

Fix reconciliation transaction editing #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nyxst4ck wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix reconciliation transaction editing #534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d55d01
fix: restrict reconciliation transaction edits
nyxst4ck Aug 21, 2026
2c238a4
fix: keep reconciliation deletion available
nyxst4ck Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 56 additions & 22 deletions lib/pages/transactions/create_transaction/create_transaction_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import '../../../ui/extensions.dart';
import "widgets/account_selector.dart";
import 'widgets/amount_section.dart';
import "widgets/category_selector.dart";
import 'widgets/details_list_disabled_tile.dart';
import 'widgets/details_list_tile.dart';
import 'widgets/duplicate_transaction_dialog.dart';
import 'widgets/label_list_tile.dart';
Expand All @@ -36,6 +37,9 @@ class _CreateTransactionPage extends ConsumerState<CreateTransactionPage> {
bool recurrencyEditingPermitted = true;
bool _isSaveEnabled = false;

bool get _isReconciliationTransaction =>
widget.transaction?.note == 'Reconciliation';

@override
void initState() {
if (widget.transaction != null) {
Expand Down Expand Up @@ -216,19 +220,20 @@ class _CreateTransactionPage extends ConsumerState<CreateTransactionPage> {
),
actions: [
if (widget.transaction != null) ...[
IconButton(
icon: Icon(
Icons.copy,
size: 20,
color: Theme.of(context).colorScheme.primary,
),
onPressed: () => showDialog(
context: context,
builder: (_) => DuplicateTransactionDialog(
transaction: widget.transaction!,
if (!_isReconciliationTransaction)
IconButton(
icon: Icon(
Icons.copy,
size: 20,
color: Theme.of(context).colorScheme.primary,
),
onPressed: () => showDialog(
context: context,
builder: (_) => DuplicateTransactionDialog(
transaction: widget.transaction!,
),
),
),
),
IconButton(
icon: Icon(
Icons.delete_outline,
Expand Down Expand Up @@ -299,10 +304,24 @@ class _CreateTransactionPage extends ConsumerState<CreateTransactionPage> {
color: Theme.of(context).colorScheme.surface,
child: Column(
children: [
LabelListTile(noteController),
if (_isReconciliationTransaction)
NonEditableDetailsListTile(
title: 'Label',
icon: Icons.label_outline,
value: noteController.text,
)
else
LabelListTile(noteController),
const Divider(),
if (selectedType != TransactionType.transfer) ...[
DetailsListTile(
if (_isReconciliationTransaction)
NonEditableDetailsListTile(
title: "Account",
icon: Icons.account_balance_wallet,
value: ref.watch(selectedBankAccountProvider)?.name,
)
else
DetailsListTile(
title: "Account",
icon: Icons.account_balance_wallet,
value: ref.watch(selectedBankAccountProvider)?.name,
Expand All @@ -329,9 +348,16 @@ class _CreateTransactionPage extends ConsumerState<CreateTransactionPage> {
),
);
},
),
),
const Divider(),
DetailsListTile(
if (_isReconciliationTransaction)
NonEditableDetailsListTile(
title: "Category",
icon: Icons.list_alt,
value: ref.watch(selectedCategoryProvider)?.name,
)
else
DetailsListTile(
title: "Category",
icon: Icons.list_alt,
value: ref.watch(selectedCategoryProvider)?.name,
Expand All @@ -358,10 +384,17 @@ class _CreateTransactionPage extends ConsumerState<CreateTransactionPage> {
),
);
},
),
),
const Divider(),
],
DetailsListTile(
if (_isReconciliationTransaction)
NonEditableDetailsListTile(
title: "Date",
icon: Icons.calendar_month,
value: ref.watch(selectedDateProvider).formatEDMY(),
)
else
DetailsListTile(
title: "Date",
icon: Icons.calendar_month,
value: ref.watch(selectedDateProvider).formatEDMY(),
Expand Down Expand Up @@ -401,11 +434,12 @@ class _CreateTransactionPage extends ConsumerState<CreateTransactionPage> {
}
}
},
),
RecurrenceListTile(
recurrencyEditingPermitted: recurrencyEditingPermitted,
selectedTransaction: widget.transaction,
),
),
if (!_isReconciliationTransaction)
RecurrenceListTile(
recurrencyEditingPermitted: recurrencyEditingPermitted,
selectedTransaction: widget.transaction,
),
],
),
),
Expand Down
Loading